search

beemobot / docs.beemo.gg

Docs for Beemo the Discord bot (https://beemo.gg)
https://docs.beemo.gg
MIT License
10 stars 12 forks source link

Better tables #6

Closed shoaibsajid1 closed 3 years ago

shoaibsajid1 commented 3 years ago

Showcase for tables with examples perhaps?

ayubun commented 3 years ago

Interesting.. Could you deploy this branch to pages so I can see what it would look like in the web? 👀

shoaibsajid1 commented 3 years ago

Interesting.. Could you deploy this branch to pages so I can see what it would look like in the web? 👀

https://github.com/dexbiobot/beemo-docs/blob/patch-1/utility/honey.md

ayubun commented 3 years ago

Interesting.. Could you deploy this branch to pages so I can see what it would look like in the web? 👀

https://github.com/dexbiobot/beemo-docs/blob/patch-1/utility/honey.md

Oh.. yeah.. I’m dumb 🤡

ayubun commented 3 years ago

I actually like this format quite a lot and would be interested in merging this rendition. Would you be willing to apply it to all of the tables by chance?

shoaibsajid1 commented 3 years ago

I'll update it for all the available tables and later future PRs can help fine tune it. Just wanted to do one table as a proof of concept. I'll make a new PR

shoaibsajid1 commented 3 years ago

I actually like this format quite a lot and would be interested in merging this rendition. Would you be willing to apply it to all of the tables by chance?

I found 3 tables so I have updated them, in the banpool table, one row was duplicate so I fixed that as well. Please review and merge as needed

ayubun commented 3 years ago

Since this is a relatively large-ish PR, I’ll have to make my suggestions when I have time next on my PC. Don’t worry, I’m not ignoring it and I appreciate your time / contributions c:

P.S. I will probably also wait for #7 to be ready to merge, since that is a new table being made in a similar format.

shoaibsajid1 commented 3 years ago

Hey there! Thank you again for the PR c: I am sorry for the wait, I have been quite busy as of lately.

I have went ahead and added some comments to your PR. I haven't actually tested the suggestions, but they should work, or at least give you an idea of what I am going for ^^

Let me know what ya think!

I merged them and they look fine (atleast when i did a quick look). Requesting review again!