beemojs / beemo

🤖 Centralized configuration layer for dev tools. Beep boop.
https://beemo.dev
MIT License
143 stars 9 forks source link

Remove driver-babel as dependency of driver-jest #83

Closed matchai closed 3 years ago

matchai commented 4 years ago

Hey Miles! 👋

Working on a Jest Beemo config, I have noticed that driver-babel is depended on by driver-jest. I see this making sense if the config is going to be using Babel to transpile TypeScript, but in my own use case, I use ts-jest and have no use for a Babel driver or config.

I'm currently using a fork of driver-jest with the dependency removed, and it appears to work perfectly.

What is the purpose of that dependency? Do you think it would be worthwhile to make Babel optional here?

milesj commented 4 years ago

@matchai It's a dependency since Babel is a direct dependency of Jest. It's meant to match how upstream works.

matchai commented 4 years ago

Ah, gotcha. 👌 Thanks for the explanation!

Since Babel configuration is optional for the use of Jest itself, it would seem sensible to me that babel configuration be optional, but be used when available.

Jest, by default, will use babel.config.js when present in the project root, so there shouldn't need to be anything else to add for it to work that way.

milesj commented 4 years ago

Yeah I can look into this. Seems like a breaking change though so would have to wait for v2.

milesj commented 3 years ago

Changed in v2.