beemojs / conventional-pr-action

GitHub Action that validates the PR title and commits against a Conventional Commits preset.
12 stars 3 forks source link

Auto install assumes a package.json in the base folder and breaks if one is not found #25

Closed bbugh closed 3 years ago

bbugh commented 3 years ago

As title says, the action expects that a package.json is in the root folder, which is not always the case for monorepos. If a package.json is not found, creating one before running npm ci would resolve this issue.

milesj commented 3 years ago

@bbugh Just curious, where is your package.json located?

Can probably provide an option to customize the path.

bbugh commented 3 years ago

Hi! Thanks for the quick response. The repo in question does not have a package.json, as it does not use any JavaScript.

milesj commented 3 years ago

@bbugh Oh wow, never even thought about this being used in a non-JS project 😅

Auto-creating it seems like a viable solution then.

milesj commented 3 years ago

Added, but havent tested thoroughly