beemojs / conventional-pr-action

GitHub Action that validates the PR title and commits against a Conventional Commits preset.
12 stars 3 forks source link

Commits whose titles start with `feat:` are considered invalid #30

Closed mykola-mokhnach closed 2 years ago

mykola-mokhnach commented 2 years ago

Steps to reproduce:

Actual result: The validation fails.This does not happen for other valid prefixes, like ci: or docs:. See https://github.com/appium/appium-uiautomator2-driver/runs/8222140787?check_suite_focus=true

Expected result: All prefixes defined at https://www.conventionalcommits.org/en/v1.0.0/ must be recognized as valid ones.

milesj commented 2 years ago

@mykola-mokhnach This actions defaults to this preset, https://github.com/beemojs/conventional-changelog-beemo, which does not support feat. You'd need to configure the action with the config-preset option and change it to angular, or whatever preset you'd like.

mykola-mokhnach commented 2 years ago

Thanks, I will change the config. Perhaps it would be easier to catch such issues if presets would have more detailed description in the documentation.