search

beemojs / conventional-pr-action

GitHub Action that validates the PR title and commits against a Conventional Commits preset.
12 stars 3 forks source link

Action doesn't actually follow commitlint convention #32

Closed ThomasAribart closed 6 months ago

ThomasAribart commented 2 years ago

Hello and thanks for you work !

I found out that action fails when using valid commit types like feat and refactor. Is it normal ? Am I doing something wrong ?

https://commitlint.js.org/#/

milesj commented 2 years ago

@ThomasAribart You need to change the config-preset option, it defaults to https://github.com/beemojs/conventional-changelog-beemo

ThomasAribart commented 2 years ago

Alright thanks @milesj !

Isn't it strange that conventional-changelog-beemo doesn't follow commitlint convention though ?

milesj commented 2 years ago

@ThomasAribart Nope, because that's the point of presets, they're all different.

You're probably referring to the Angular preset.