search

beepbeepimatrain / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

Filter feature in gtk gui #43

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Create rom browser filter feature to match kde4 gui. Reference image attached.

Original issue reported on code.google.com by ebenbl...@gmail.com on 8 Apr 2008 at 5:53

Attachments:

GoogleCodeExporter commented 8 years ago 
Tillin9 fixed this issue, waiting on the commit changes... for now setting this 
issue
to fixed.

Original comment by sgorman07@gmail.com on 22 Apr 2008 at 5:36

GoogleCodeExporter commented 8 years ago 
Don't set it to fixed until the code is tested and committed to trunk.

Original comment by ebenbl...@gmail.com on 22 Apr 2008 at 6:07

GoogleCodeExporter commented 8 years ago 
Transferring this to Tillin9 since okaygo said he's working on the fix.

Original comment by ebenbl...@gmail.com on 22 Apr 2008 at 6:08

GoogleCodeExporter commented 8 years ago 
Commit 271 addresses this. 

Everything seems to work fine, but I no longer have as many GoodNames. I don't 
see 
how my code could have caused this though.

Original comment by sknau...@wesleyan.edu on 22 Apr 2008 at 1:13

GoogleCodeExporter commented 8 years ago 
Commit 272 fixes this, there was a collision as the Gtk GUI was updated 
inbetween 
my local branch and the svn that I didn't detected at first. Setting to fixed.

Original comment by sknau...@wesleyan.edu on 22 Apr 2008 at 1:58

GoogleCodeExporter commented 8 years ago 
This is a great feature, thanks for implementing it! I changed the filter so it
filters as the user types instead of requiring them to press enter.

I did hit one issue with the change. Call me crazy, but I can't type the letter 
'p'
into the filter textbox. It just won't appear. If I have time later, I'll try to
debug it. I've used GtkEntry's in other dialogs and never seen this problem...

Original comment by ebenbl...@gmail.com on 22 Apr 2008 at 3:03

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I'm glad you like ti! The lowercase p is from SDL taking it for pause / 
continue. I 
suggest we might want to change that to another key combination. 

As far as types, I didn't do that since it takes a lot of CPU overhead, well, 
at 
least on my machine. Remember that since GtkTreeModelSort can't wrap 
GtkTreeModelFilter we need to manually copy the ROM list every time we filter. 
If 
you have the whole GoodROM set (which is why I added sorting and filtering to 
the 
GUI in the first place) this introduces noticeable slowdown.

Anyway... its trivial to change back and forth, and if users like it better, I 
have 
no problem.

Original comment by sknau...@wesleyan.edu on 22 Apr 2008 at 3:55

GoogleCodeExporter commented 8 years ago 
oh ouch, you're right, it's because I set 'p' as the gtk accelerator for
pause/continue. That sucks that gtk doesn't also forward the 'p' to the entry 
widget.
I'll need to look into working this out. Not being able to type 'p' into the 
filter
sucks.

Original comment by ebenbl...@gmail.com on 22 Apr 2008 at 3:55

GoogleCodeExporter commented 8 years ago 
we should probably add a configuration switch to allow the user to set "live 
search"
or not.

Original comment by ebenbl...@gmail.com on 22 Apr 2008 at 3:57