search

beeradmoore / Xam.Plugin.Mixpanel.iOS

Xamarin.iOS bindings for Mixpanel (Objective-C)
Apache License 2.0
8 stars 2 forks source link

Upgrade Mixpanel to 3.5.0? #3

Closed LuoyeAn closed 5 years ago

LuoyeAn commented 5 years ago

Hi, is it possbile to upgrade Mixpanel nuget to 3.5.0?

beeradmoore commented 5 years ago

I think you mean 3.5.0? I have an internal build we are testing with those updates. If they go good Ill bring them into this repo and push out a nuget in the next 24-48 hours.

LuoyeAn commented 5 years ago

oh, yea, thanks! @beeradmoore Could we update to latest version for Mixpanel.Android?

beeradmoore commented 5 years ago

I also have that in testing :)

beeradmoore commented 5 years ago

Update on this, Android testing isn't going well. Project doesn't seem to find the namespace, but if I extract the dll from the NuGet Package and add it manually it works. Still investigating that. Wanting to double check your PR with re-doing objective sharpie to see if all bindings are found but my local cocoaods (or objective sharpie) does not want to work.

I'll keep you updated and let you know when the nuget is ready.

LuoyeAn commented 5 years ago

It looks fine on my mac with your latest android source code.
Screen Shot 2019-10-31 at 11 08 21 AM

Do you want I give you the nupkg file?

And are there some issues on iOS plugin also？

beeradmoore commented 5 years ago

Oh, interesting... For me the Xam.Plugin.Mixpanel namespace isn't found. This is part the reason why I am going to format and re-install. My dev environment has gone bonkers.

I just want to verify with both iOS and Android that there are no new APIs added. I think from your PR there was one new one.

I tried to re-bind the iOS build with objective sharpie but that gave me all sorts of errors. As above, things are broken here. Time to format.

beeradmoore commented 5 years ago

3.5.0 nuget was released. Thanks for your PR! Android code is commited for 5.6.5, however I am going to look into reducing its 136 build warnings before I do a nuget release of it.

beeradmoore commented 5 years ago

@TingtingAn , Android package has been sent off to nuget.org