[BUG] [1.0.4.0] "Double" entry with DLSS 3.5.10 displayed

beeradmoore / dlss-swapper

GNU General Public License v3.0

1.75k stars 62 forks source link

[BUG] [1.0.4.0] "Double" entry with DLSS 3.5.10 displayed #191

Closed Rool-IO closed 9 months ago

Rool-IO commented 11 months ago

Describe the bug After updating from 1.0.3.1 to 1.0.4.0 I have a blank entry showing up with DLSS version 3.5.10 If I group games from the same library, it shows up in the GOG section but I don't have any other GOG installed game (Galaxy or offline)

To Reproduce Don't know how, it just is

Expected behavior No blank entry displayed

Screenshots 2023-12-25 113613 2023-12-25 113551

Additional context I tried to find out what nvngx_dlss(*).dll file could be left somewhere in GOG Galaxy's sub-folders (no other GOG game installed elsewhere anyway) but I can't figure it out as there's only the ones from installed games.

Rool-IO commented 10 months ago

So it's not a blank entry, it's a nonsensical "double" (Which I couldn't even read when in light mode) :

beeradmoore commented 10 months ago

First thought was to check dark mode and yep 2 issues.

Text issue.

I'll grab phantom liberty and see why this is. Does it show up as one entry when you are looking in Steam at your library?

Rool-IO commented 10 months ago

Thanks for looking into this.

It does only show as one entry but it's in GOG Galaxy, not Steam. But if added as a non-steam game, it only shows as one entry in there too.

beeradmoore commented 10 months ago

Oh I see now.

I'll look into

white text in light mode
game showing up in GOG twice, once without an image
non-steam game being added into Steam itself shows in the Steam list as well (I think that's what you mean?)

Rool-IO commented 10 months ago

No, I just meant the GOG Galaxy and Steam desktop clients respectively. Just to clarify, CP2077 is a GOG Galaxy install, I have already added it to Steam as a non-steam game, in both cases it shows up as one entry only in the clients, it's just DLSS Swapper that "doubled" it for some reason after updating to 1.0.4.0. Screenshots reflect all there is to it (visually)

beeradmoore commented 10 months ago

Looking into it and found the problem. It isn't anything to do with Steam as to why its doubling up.

GOG Galaxy creates a second entry for installed game if a game is a DLC. That is why Phantom Liberty shows up like that. I double checked by grabbing some other random DLC of one of my other test games.

Lucky enough the entry of the DLC is easy enough to determine its a DLC and I can hide it.

Rool-IO commented 10 months ago

Great news ! Glad it's an easy fix (I guess the text one is too)

beeradmoore commented 10 months ago

Thanks for reporting it! I'll close this issue and let you know when a release is out (may be a day or two incase any other issues pop up)

Rool-IO commented 10 months ago

Apologies for this late update : I forgot to mention I'm using the following system option for the theme (if it's of any help for the text issue)

Rool-IO commented 9 months ago

Hey @beeradmoore , sorry to ask but is there any progress on an update with those fixes ?

beeradmoore commented 9 months ago

Hey @Rool-IO No, I am the sorry one. This was fixed long ago but I forgot to get it published. I went on and instead stuck my head into the DLSS 3/FG updates.

This is now published here, https://github.com/beeradmoore/dlss-swapper/releases/tag/v1.0.5.0

Thanks again for filing an issue, and thanks for bumping this to remind me!

Rool-IO commented 9 months ago

No problem, that's good stuff to get your head stuck into. I had mine stuck into it as well.

You're very welcome. Thanks a lot.