search

beetbox / audioread

cross-library (GStreamer + Core Audio + MAD + FFmpeg) audio decoding for Python
MIT License
481 stars 108 forks source link

ffdec: Ensure that QueueReaderThreads have stopped before closing pipes #80

Closed ssssam closed 5 years ago

ssssam commented 5 years ago

This is a follow up from 8d10f7b (https://github.com/beetbox/audioread/pull/78)

The previous fix was enough to stop my test case from crashing, but when running beet import the problem would still occur.

sampsyo commented 5 years ago

Got it! This makes sense to me—we should indeed be joining the threads at some point, and doing that before closing the streams is clearly the right place to do it. I'll try this out and then merge.