Better subprocess error handling

beetbox / audioread

cross-library (GStreamer + Core Audio + MAD + FFmpeg) audio decoding for Python

MIT License

481 stars 108 forks source link

Better subprocess error handling #88

Closed ghost closed 5 years ago

ghost commented 5 years ago

The console window which opens every time when accessing ffmpeg sucks. This PR will stop this behaviour. Additionally also subprocess.CalledProcessErrors are catched.

ghost commented 5 years ago

Sorry guys, I am a little idiot, I didn't see that this creationflag is added in the release 3.7... Travis CI is right...

ghost commented 5 years ago

I will close it for now and come back in 2020 (2.7 EOL)

sampsyo commented 5 years ago

OK! But it would still be cool to at least pass the flag that avoids creating a window, which shouldn’t be too hard—we just need to check the Python version before doing so. Any interest in committing that now, behind a version threshold condition?

ghost commented 5 years ago

Sure, opened clean PR #89.