search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.78k stars 1.82k forks source link

chroma: Avoid repeated acoustid submissions #1084

Open johtso opened 9 years ago

johtso commented 9 years ago

Currently there is nothing at all preventing you from submitting the same fingerprints more than once, and it is very easy to accidentally do.

The acoustid service also does no duplicate checking, so submitting duplicate fingerprints inflates the count/weight of that submission which is pretty bad.

Tools like musicbrainz picard prevent you from submitting fingerprints multiple times afaik.

Hawke commented 9 years ago

Just want to comment that this is IMO not a bug: The AcoustID server could easily do the duplicate checking (it could even recount the submissions to get an accurate count of unique submitters for each fingerprint). Picard prevents you from submitting an already-attached fingerprint, but this also requires that it check AcoustID for an already-associated fingerprint each time it’s loaded, which is a lot more client-side work/traffic. For beets to do this, it would have to do a lookup for the entire library, every time it ran.

johtso commented 9 years ago

beets could set some kind of a local flag after submitting a fingerprint though right? That would at least avoid repeat submissions as long as you don't nuke your whole library.

Hawke commented 9 years ago

Yeah, that would work.

sampsyo commented 9 years ago

I was just about to suggest that—it would be pretty straightforward to have the plugin set a acoustid_submitted flexible attribute. It's not foolproof, of course, since this won't be preserved if someone imports the same album twice, but it should at the very least cut down on beet submit time.