beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.77k stars 1.82k forks source link

Compilation flag inference in as-is imports is inconsistent with update behavior #1099

Open busybit opened 9 years ago

busybit commented 9 years ago

When I import a compilation with "Use as is", and after that run "beet update", the comp: flag is set to false and the album is split by artist into many artist folders.

sampsyo commented 9 years ago

Can you verify that the flag is in fact set on all the files in the album (perhaps by using the beet info plugin command)? The update command reads the tags into the database, so that would be expected.

busybit commented 9 years ago

Yes, all comp: flags are True. This is the info from one album:

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/02 Cash Talkin. (The Workingman.s Blues).mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Albert Collins artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7524 initial_key: label: language: length: 270.0 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Cash Talkin. (The Workingman.s Blues) track: 02 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/10 I Will Not Be Denied.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Bonnie Raitt artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7532 initial_key: label: language: length: 291.3 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: I Will Not Be Denied track: 10 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/06 Turtle Blues.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Bonnie Taylor artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7528 initial_key: label: language: length: 252.7 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Turtle Blues track: 06 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/05 Railroad Blues (LiveAt Leeds).mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Brendan Croker & The 5 O.Clock Shadows artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7527 initial_key: label: language: length: 311.7 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Railroad Blues (LiveAt Leeds) track: 05 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/08 Why.d You Lie.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Colin James artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7530 initial_key: label: language: length: 326.9 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Why.d You Lie track: 08 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/13 Same Old Blues.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Eric Clapton artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7535 initial_key: label: language: length: 494.7 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Same Old Blues track: 13 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/01 King Of The Blues.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Gary Moore artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7523 initial_key: label: language: length: 273.8 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: King Of The Blues track: 01 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/09 Inner City Blues.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Joe Cocker artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7531 initial_key: label: language: length: 347.2 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Inner City Blues track: 09 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/03 The Healer.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: John Lee Hooker With Carlos Santana & The Santana Band artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7525 initial_key: label: language: length: 339.5 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: The Healer track: 03 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/11 Mr. Cab Driver.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Lenny Kravitz artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7533 initial_key: label: language: length: 232.5 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Mr. Cab Driver track: 11 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/12 Let.s Call The Whole Thing Off.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Ray Charles artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7534 initial_key: label: language: length: 190.2 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Let.s Call The Whole Thing Off track: 12 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/04 Everyday Now.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: Texas artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7526 initial_key: label: language: length: 274.3 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Everyday Now track: 04 tracktotal: 00 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/07 Itchy Feet.mp3 acoustid_fingerprint: acoustid_id: added: 2014-11-18 06:52:19 album: It.s Blues Vol. 1 album_id: 642 albumartist: Various Artists albumartist_credit: albumartist_sort: albumdisambig: albumstatus: albumtype: artist: The Blues Band artist_credit: artist_sort: artpath: None asin: bitdepth: 0 bitrate: 160kbps bpm: 0 catalognum: channels: 2 comments: comp: True composer: country: day: 00 disc: 00 disctitle: disctotal: 00 encoder: format: MP3 genre: Blues grouping: id: 7529 initial_key: label: language: length: 199.2 lyrics: mb_albumartistid: mb_albumid: mb_artistid: mb_releasegroupid: mb_trackid: media: month: 00 mtime: 1970-01-01 01:00:00 original_day: 00 original_month: 00 original_year: 0000 rg_album_gain: 0.0 rg_album_peak: 0.0 rg_track_gain: 0.0 rg_track_peak: 0.0 samplerate: 44kHz script: singleton: False title: Itchy Feet track: 07 tracktotal: 00 year: 1990

And this is the output from "beet update -p":

Albert Collins - It.s Blues Vol. 1 - Cash Talkin. (The Workingman.s Blues) albumartist: Various Artists -> Albert Collins comp: True -> False Bonnie Raitt - It.s Blues Vol. 1 - I Will Not Be Denied albumartist: Various Artists -> Bonnie Raitt comp: True -> False Bonnie Taylor - It.s Blues Vol. 1 - Turtle Blues albumartist: Various Artists -> Bonnie Taylor comp: True -> False Brendan Croker & The 5 O.Clock Shadows - It.s Blues Vol. 1 - Railroad Blues (LiveAt Leeds) albumartist: Various Artists -> Brendan Croker & The 5 O.Clock Shadows comp: True -> False Colin James - It.s Blues Vol. 1 - Why.d You Lie albumartist: Various Artists -> Colin James comp: True -> False Eric Clapton - It.s Blues Vol. 1 - Same Old Blues albumartist: Various Artists -> Eric Clapton comp: True -> False Gary Moore - It.s Blues Vol. 1 - King Of The Blues albumartist: Various Artists -> Gary Moore comp: True -> False Joe Cocker - It.s Blues Vol. 1 - Inner City Blues albumartist: Various Artists -> Joe Cocker comp: True -> False John Lee Hooker With Carlos Santana & The Santana Band - It.s Blues Vol. 1 - The Healer albumartist: Various Artists -> John Lee Hooker With Carlos Santana & The Santana Band comp: True -> False Lenny Kravitz - It.s Blues Vol. 1 - Mr. Cab Driver albumartist: Various Artists -> Lenny Kravitz comp: True -> False Ray Charles - It.s Blues Vol. 1 - Let.s Call The Whole Thing Off albumartist: Various Artists -> Ray Charles comp: True -> False Texas - It.s Blues Vol. 1 - Everyday Now albumartist: Various Artists -> Texas comp: True -> False The Blues Band - It.s Blues Vol. 1 - Itchy Feet albumartist: Various Artists -> The Blues Band comp: True -> False

sampsyo commented 9 years ago

That's odd. I can't reproduce this locally. Can you share one of these files so we can run tests on our end?

sampsyo commented 9 years ago

And just to check: when you used beet info, you got the file tags, not the library tags, right?

busybit commented 9 years ago

I did the beet info with "-l album:"albumname". How can I share the album with you? I'm now at work and can send you the album tonight.

sampsyo commented 9 years ago

The -l flag shows data from the database. Can you please try again without it?

busybit commented 9 years ago

I can test this on afternoon (after work). After studiying the code I have one idea: On importing beet guesses if a album is a compilation and sets albumartist and comp tag (method align_album_level_fields()).

Could it be that these both tags are not written to file when importing "as is"?

The "beet update" reads the tags from file and does not call align_album_level_fields(), so they mismatch and update will change them.

sampsyo commented 9 years ago

Indeed, thanks for investigating. Importing as-is (intentionally) avoids modifying your files.

It may make sense to do a similar "alignment" on update, I think, even if that means not literally interpreting the tags as they are on the files. I do worry that this could be confusing, though, if someone intentionally tries to change that flag to false.

In the mean time, I suppose you could write the inferred flag back to files with thebeet write command.

busybit commented 9 years ago

I did a "beet info" to verify this. It is as assumed, the comp tag is missing in the files. My first thought was to do the same alignment on update, but how can we distinguish if a file was imported "asis", or with tags from Musicbrainz? In the case of import I get the choice, but this is not the case on update. And I think we should handle this the same way as on import, do the alignment only on files that were imported "as is". Would it be better to modify the tags on import also in the "as is" case? Then nothing has to be changed in the update logic.

This are the tags read from file:

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/02 Cash Talkin. (The Workingman.s Blues).mp3 album: It.s Blues Vol. 1 art: False artist: Albert Collins bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 270.0016 samplerate: 44100 title: Cash Talkin. (The Workingman.s Blues) track: 2 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/10 I Will Not Be Denied.mp3 album: It.s Blues Vol. 1 art: False artist: Bonnie Raitt bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 291.34365 samplerate: 44100 title: I Will Not Be Denied track: 10 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/06 Turtle Blues.mp3 album: It.s Blues Vol. 1 art: False artist: Bonnie Taylor bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 252.70855 samplerate: 44100 title: Turtle Blues track: 6 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/05 Railroad Blues (LiveAt Leeds).mp3 album: It.s Blues Vol. 1 art: False artist: Brendan Croker & The 5 O.Clock Shadows bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 311.6669 samplerate: 44100 title: Railroad Blues (LiveAt Leeds) track: 5 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/08 Why.d You Lie.mp3 album: It.s Blues Vol. 1 art: False artist: Colin James bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 326.92245 samplerate: 44100 title: Why.d You Lie track: 8 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/13 Same Old Blues.mp3 album: It.s Blues Vol. 1 art: False artist: Eric Clapton bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 494.6808 samplerate: 44100 title: Same Old Blues track: 13 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/01 King Of The Blues.mp3 album: It.s Blues Vol. 1 art: False artist: Gary Moore bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 273.8155 samplerate: 44100 title: King Of The Blues track: 1 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/09 Inner City Blues.mp3 album: It.s Blues Vol. 1 art: False artist: Joe Cocker bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 347.2457 samplerate: 44100 title: Inner City Blues track: 9 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/03 The Healer.mp3 album: It.s Blues Vol. 1 art: False artist: John Lee Hooker With Carlos Santana & The Santana Band bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 339.53955 samplerate: 44100 title: The Healer track: 3 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/11 Mr. Cab Driver.mp3 album: It.s Blues Vol. 1 art: False artist: Lenny Kravitz bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 232.4898 samplerate: 44100 title: Mr. Cab Driver track: 11 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/12 Let.s Call The Whole Thing Off.mp3 album: It.s Blues Vol. 1 art: False artist: Ray Charles bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 190.2498 samplerate: 44100 title: Let.s Call The Whole Thing Off track: 12 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/04 Everyday Now.mp3 album: It.s Blues Vol. 1 art: False artist: Texas bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 274.33795 samplerate: 44100 title: Everyday Now track: 4 year: 1990

/home/jochen/Musik/Compilations/It.s Blues Vol. 1/07 Itchy Feet.mp3 album: It.s Blues Vol. 1 art: False artist: The Blues Band bitdepth: 0 bitrate: 160000 channels: 2 date: 1990-01-01 format: MP3 genre: Blues genres: Blues length: 199.15755 samplerate: 44100 title: Itchy Feet track: 7 year: 1990

sampsyo commented 9 years ago

Would it be better to modify the tags on import also in the "as is" case?

I'm not sure—the downside to this approach would be that it violates the user's expectation that files are imported without modification. Although we're considering changing that, at least for plugins, in #726.

There's no one obvious solution here. I'd be interested to hear from any other users about what they expect from "as-is" imports and the update command.

Kraymer commented 9 years ago

/me realize we cannot start issue in github

assigning it to myself as I plan to do it one day and will forget it otherwise ...

lfam commented 9 years ago

I'd be interested to hear from any other users about what they expect from "as-is" imports and the update command.

I just experienced this issue and it absolutely not what I expected to happen. As-is imports should stay as-are.

DirkReiners commented 8 years ago

This just bit me... The current behavior is really non-intuitive and potentially very destructive (I now have hundreds of directories with one song each...).

My workaround was to manually set the compilation flag (using mid3v2 --TCMP 1 _/mp3) and update again. But I was lucky, the disassembled compilations ended up in one exclusive folder, making that possible. A preventative could be to run mid3v2 --TCMP 1 /Compilations/_/mp3 */Compilations//_/_mp3 before running update, but that's pretty brutal, and you need to know about it before you do the update...

Is anybody working on this?

sampsyo commented 8 years ago

No, I don't think anyone's working on it—any interest in picking it up?

So I can understand a little more, what do you think the right fix would be? We could, as two examples, just stop doing comp flag inference at all on as-is imports, or we could change the update command instead to do the same thing as import -A.

m42i commented 7 years ago

As suggested in #2181 I'd refrain from guessing the album artist on importing.