claunia
commented
9 years ago Disabling keyfinder plugin stops crashing.
Keyfinder configuration: keyfinder: bin: /Applications/KeyFinder.app/Contents/MacOS/KeyFinder auto: yes overwrite: no
Closed claunia closed 9 years ago
claunia
commented
9 years ago Disabling keyfinder plugin stops crashing.
Keyfinder configuration: keyfinder: bin: /Applications/KeyFinder.app/Contents/MacOS/KeyFinder auto: yes overwrite: no
sampsyo
commented
9 years ago Hi! Thank you for reporting. I believe this should be fixed in git due to some recent refactoring of the logging machinery. If you get a chance, can you confirm that this is working now?
claunia
commented
9 years ago Unfortunately using git master just changes the error:
Traceback (most recent call last):
File "/usr/local/bin/beet", line 9, in
sampsyo
commented
9 years ago Wow, a completely different bug! Thanks for reporting. Looking into this now.
sampsyo
commented
9 years ago I took a closer look and found several glaring issues in the keyfinder plugin. :scream: They should be fixed now.
claunia
commented
9 years ago Good, updating to master of masters and testing, stay tuned :stuck_out_tongue:
claunia
commented
9 years ago I have a new bug, but at least, now, it doesn't stop importing:
Logged from file keyfinder.py, line 63
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 851, in emit
msg = self.format(record)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 724, in format
return fmt.format(record)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 467, in format
s = self._fmt % record.__dict__
File "/Library/Python/2.7/site-packages/beets/logging.py", line 46, in __str__
return self.msg.format(*self.args, **self.kwargs)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xcc in position 139: ordinal not in range(128)
Logged from file keyfinder.py, line 63Thank you again, and my apologies for the number of bugs you're uncovering in this (apparently neglected) plugin. This latest one should also be fixed now.
claunia
commented
9 years ago No need to apologize, it's been my pleasure to help a fellow developer uncover and kill nasty bugs on a software I do like :+1:
darthanubis
commented
9 years ago Traceback (most recent call last):
File "/usr/bin/beet", line 9, in
beets crashes on import when getting to Insomnia: The Erick Sermon Compilation Album The Wixtons The lyrics plugin then crashes attempting to read the lyrcis.
beet lyrics Insomnia: The Erick Sermon Compilation Album The Wixtons
Traceback (most recent call last):
File "/usr/bin/beet", line 9, in
Jah Boogie: Here comes the Jah changin' faces spoiled rotten A.
Not sure if this is related to this bug, as I didn't want to create a duplicate bug report.
sampsyo
commented
9 years ago @darthanubis This is a separate bug. Can you provide a copy of your database for testing (associated with a new issue)?
Trying to import any file with unicode names, or inside a unicode-named folder, crashes in Mac OS X.
Tested with beets 1.3.8 and 1.3.10, under Mac OS X 10.9.5 and 10.10.0.
Traceback (most recent call last): File "/usr/local/bin/beet", line 9, in
load_entry_point('beets==1.3.10', 'console_scripts', 'beet')()
File "/Library/Python/2.7/site-packages/beets/ui/init.py", line 945, in main
_raw_main(args)
File "/Library/Python/2.7/site-packages/beets/ui/init.py", line 935, in _raw_main
subcommand.func(lib, suboptions, subargs)
File "/Library/Python/2.7/site-packages/beets/ui/commands.py", line 873, in import_func
import_files(lib, paths, query)
File "/Library/Python/2.7/site-packages/beets/ui/commands.py", line 845, in import_files
session.run()
File "/Library/Python/2.7/site-packages/beets/importer.py", line 305, in run
pl.run_parallel(QUEUE_SIZE)
File "/Library/Python/2.7/site-packages/beets/util/pipeline.py", line 299, in run
out = self.coro.send(msg)
File "/Library/Python/2.7/site-packages/beets/util/pipeline.py", line 181, in coro
func(*(args + (task,)))
File "/Library/Python/2.7/site-packages/beets/importer.py", line 1268, in plugin_stage
func(session, task)
File "/Library/Python/2.7/site-packages/beetsplug/keyfinder.py", line 52, in imported
self.find_key(task.items)
File "/Library/Python/2.7/site-packages/beetsplug/keyfinder.py", line 70, in find_key
.format(key, util.displayable_path(item.path)))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 104: ordinal not in range(128)