beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.87k stars 1.82k forks source link

Convert (recently) stopped respecting paths with inline #1503

Closed th0rn closed 9 years ago

th0rn commented 9 years ago

So to start off with, this used to work every time, and to the best of my memory, I haven't made any (at least related) changes to my config. It now works never, I presume because of an update, but I could be wrong.

So I have a directory with some files like:

/home/myuser/mymusiclibrarydir/Albumartist - Album (year) (flac)/XX. Title.flac
/home/myuser/mymusiclibrarydir/Albumartist - Album (year) (flac)/XY. Title 2.flac

Then I do beet convert Albumartist - Album (year)/ (with proper escapes), and I get the prompt with all the files showing. I hit Y.

What I expect to happen; files to be created as follows:

/home/myuser/music/Albumartist - Album (year)/XX. Title.mp3
/home/myuser/music/Albumartist - Album (year)/XY. Title 2.mp3

What actually happens; files are created as follows:

/home/myuser/music/Albumartist - Album (year) (flac)/XX. Title.mp3
/home/myuser/music/Albumartist - Album (year) (flac)/XY. Title 2.mp3

Difference: convert doesn't use inline for path formatting (should not show flac filetype)

Replicability: always

Relevant lines from config.yaml:

paths:
    default: $albumartist - $album ($year)$format_conditional/$track. $title
item_fields:
    format_conditional: u'' if format == 'MP3' else u' (%s)' % format.lower()
plugins: chroma convert fetchart embedart lyrics lastgenre inline
convert:
    dest: /home/myuser/music/
th0rn commented 9 years ago

Disclaimer: I'm not totally sure that it used to work with convert. It could be possible that I used to always use import instead of convert, but I don't believe that to be the case.

sampsyo commented 9 years ago

Thanks for reporting. This is an issue with $format in convert paths: please see #1360.