search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.78k stars 1.82k forks source link

Report media correctly when there is more than one type #2203

Open apastuszak opened 8 years ago

apastuszak commented 8 years ago

Problem

When you are importing a multi-disc release, where some of the discs are DVDs instead of CDs, beets seems to identify the release as being all CDs. For example, if I try and import the deluxe version of Jethro Tull's A Passion Play, I see the following:

    Jethro Tull - A Passion Play: An Extended Performance
URL:
    http://musicbrainz.org/release/2d1d2d5e-3e33-48cf-8e02-7f81cef886b5
(Similarity: 56.7%) (missing tracks) (4xCD, 2014, US, Chrysalis)
CD 1: A Passion Play (A new Steven Wilson stereo remix)
CD 2: The Château D’Hérouville Sessions (A new Steven Wilson stereo remix)
Missing tracks (64/94 - 68.1%):
 ! Lifebeats / Prelude (5.1 mix) (#31) (3:24)
 ! The Silver Cord (5.1 mix) (#32) (4:28)
 ! Re-Assuring Tune (5.1 mix) (#33) (1:11)
 ! Memory Bank (5.1 mix) (#34) (4:20)
 ! Best Friends (5.1 mix) (#35) (1:56)
 ! Critique Oblique (5.1 mix) (#36) (4:35)
 ! Forest Dance #1 (5.1 mix) (#37) (1:34)
 ! The Story of the Hare Who Lost His Spectacles (5.1 mix) (#38) (4:10)
 ! Forest Dance #2 (5.1 mix) (#39) (1:12)
 ! The Foot of Our Stairs (5.1 mix) (#40) (5:08)
 ! Overseer Overture (5.1 mix) (#41) (3:58)
 ! Flight From Lucifer (5.1 mix) (#42) (3:56)
 ! 10:08 to Paddington (5.1 mix) (#43) (1:04)
 ! Magus Perdé (5.1 mix) (#44) (3:53)
 ! Epilogue (5.1 mix) (#45) (0:44)
 ! Lifebeats / Prelude (#46) (3:24)
 ! The Silver Cord (#47) (4:28)
 ! Re-Assuring Tune (#48) (1:11)
 ! Memory Bank (#49) (4:20)
 ! Best Friends (#50) (1:56)
 ! Critique Oblique (#51) (4:35)
 ! Forest Dance #1 (#52) (1:34)
 ! The Story of the Hare Who Lost His Spectacles (#53) (4:10)
 ! Forest Dance #2 (#54) (1:12)
 ! The Foot of Our Stairs (#55) (5:08)
 ! Overseer Overture (#56) (3:58)
 ! Flight From Lucifer (#57) (3:56)
 ! 10:08 to Paddington (#58) (1:04)
 ! Magus Perdé (#59) (3:53)
 ! Epilogue (#60) (0:44)
 ! A Passion Play, Part 1 (original 1973 stereo mix) (#61) (23:08)
 ! A Passion Play, Part 2 (original 1973 stereo mix) (#62) (22:00)
 ! The Story of the Hare Who Lost His Spectacles (tour footage) (#63) (7:21)
 ! Opening/Closing Ballet Sequences (tour footage) (#64) (3:56)
 ! The Big Top (5.1 mix) (#65) (3:05)
 ! Scenario (5.1 mix) (#66) (3:25)
 ! Audition (5.1 mix) (#67) (2:33)
 ! Skating Away on the Thin Ice of the New Day (5.1 mix) (#68) (3:27)
 ! Sailor (5.1 mix) (#69) (3:10)
 ! No Rehearsal (5.1 mix) (#70) (5:09)
 ! Left Right (5.1 mix) (#71) (5:02)
 ! Only Solitaire (5.1 mix) (#72) (1:28)
 ! Critique Oblique, Part I (5.1 mix) (#73) (8:50)
 ! Critique Oblique, Part II (5.1 mix) (#74) (5:28)
 ! Animelee (1st Dance) (5.1 mix) (#75) (3:36)
 ! Animelee (2nd Dance) (5.1 mix) (#76) (1:34)
 ! Law of the Bungle, Part I (5.1 mix) (#77) (5:08)
 ! Tiger Toon (5.1 mix) (#78) (2:31)
 ! Law of the Bungle, Part II (5.1 mix) (#79) (5:28)
 ! The Big Top (#80) (3:05)
 ! Scenario (#81) (3:25)
 ! Audition (#82) (2:33)
 ! Skating Away on the Thin Ice of the New Day (#83) (3:27)
 ! Sailor (#84) (3:10)
 ! No Rehearsal (#85) (5:09)
 ! Left Right (#86) (5:02)
 ! Only Solitaire (#87) (1:28)
 ! Critique Oblique, Part I (#88) (8:50)
 ! Critique Oblique, Part II (#89) (5:28)
 ! Animelee (1st Dance) (#90) (3:36)
 ! Animelee (2nd Dance) (#91) (1:34)
 ! Law of the Bungle, Part I (#92) (5:08)
 ! Tiger Toon (#93) (2:31)
 ! Law of the Bungle, Part II (#94) (5:28)
Apply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort? ^CException in thread Thread-10:

The release contains 2 CD and 2 DVDs. I fully expect it not to be a 100% match, but I am also expecting it to tell me there are 2 CD and 2 DVDs, which helps me understand why it doesn't match.

Running this command in verbose (-vv) mode:

user configuration: /home/andy/.config/beets/config.yaml
data directory: /home/andy/.config/beets
plugin paths:
Sending event: pluginload
lyrics: Disabling google source: no API key configured.
library database: /home/andy/Documents/library.db
library directory: /mnt/storage/music_library
Sending event: library_opened
Sending event: import_begin
Sending event: import_task_created
Sending event: import_task_start
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/01 Lifebeats _ Prelude.flac'
chroma: matched recordings [u'eeaadf40-2ebd-4baa-b4b5-0606a83db5c5'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/02 The Silver Cord.flac'
chroma: matched recordings [u'36d54840-53d9-424a-b8af-83bfbb58230f'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/03 Re-Assuring Tune.flac'
chroma: matched recordings [u'ec0fa444-5fa2-4829-92da-a8e867cb975d'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/04 Memory Bank.flac'
chroma: matched recordings [u'8c6a4380-1d72-4631-91b8-cf6470bbff5e'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/05 Best Friends.flac'
chroma: matched recordings [u'bdfca336-d74b-48dd-967d-88365765c885'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/06 Critique Oblique.flac'
chroma: matched recordings [u'1eedbd27-703a-40a9-8374-1f463a2efb4e'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/07 Forest Dance #1.flac'
chroma: matched recordings [u'8a6d5b34-95c3-405d-b5b9-342a95cdfe64'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/08 The Story of the Hare Who Lost His Spectacles.flac'
chroma: matched recordings [u'6fddac66-2df8-41c6-be65-db5298ccb7f7'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/09 Forest Dance #2.flac'
chroma: matched recordings [u'892c2de3-9d8c-47df-9bcd-f83506c6c6dc'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/10 The Foot of Our Stairs.flac'
chroma: matched recordings [u'ffe37679-f02d-4fe1-8712-1ee5b53a7e87'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/11 Overseer Overture.flac'
chroma: matched recordings [u'1c6c7cd3-53da-4bc3-bb6d-767e51805241'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/12 Flight From Lucifer.flac'
chroma: matched recordings [u'678e100d-3c4d-446a-b8cb-ea9bfb9abb4a'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/13 10_08 to Paddington.flac'
chroma: matched recordings [u'dfb82c34-62cf-4de8-bb00-d1d708be0a2b'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/14 Magus Perd\xc3\xa9.flac'
chroma: matched recordings [u'22a62c65-6b66-40af-b7f3-6fae606cdce7'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/15 Epilogue.flac'
chroma: matched recordings [u'a2e16ce3-7454-4bb4-891f-63e05f278955'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/16 The Big Top.flac'
chroma: matched recordings [u'c9309dab-9dd2-4157-983b-c23a696bb6ed'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/17 Scenario.flac'
chroma: matched recordings [u'da991193-d1bc-4ddb-ae5a-525a845b4523'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/18 Audition.flac'
chroma: matched recordings [u'e43f23d1-0efb-4f22-b66c-c6850ac803c2'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/19 Skating Away on the Thin Ice of the New Day.flac'
chroma: matched recordings [u'3950d719-6135-4428-ba91-ecf87da700ae'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/20 Sailor.flac'
chroma: matched recordings [u'17aed00a-4286-433e-a595-7c55e564936d'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/21 No Rehearsal.flac'
chroma: matched recordings [u'68430569-26b6-45a8-8519-139ecb68a384'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/22 Left Right.flac'
chroma: matched recordings [u'1909ea3f-721c-4572-9e04-683fd2804f7d'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/23 Only Solitaire.flac'
chroma: matched recordings [u'97ff5c06-2699-4b0f-8faf-8eff6fe636c1'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/24 Critique Oblique, Part I.flac'
chroma: matched recordings [u'862cb786-af57-4dfb-843e-79065a186f7e'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/25 Critique Oblique, Part II.flac'
chroma: matched recordings [u'4eac9dda-e5b0-47ce-a656-b3671c953605'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/26 Animelee (1st Dance).flac'
chroma: matched recordings [u'9b4e8af5-ab7c-4357-a678-abf4a433338c'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/27 Animelee (2nd Dance).flac'
chroma: matched recordings [u'9f540be8-eb9f-4717-855e-ab7fc6cd9d4c'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/28 Law of the Bungle, Part I.flac'
chroma: matched recordings [u'9dcbfc6c-65d6-4184-ac93-7a02ab94bd36'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/29 Tiger Toon.flac'
chroma: matched recordings [u'552c8ca2-478f-4317-8595-b157aa51ec71'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
chroma: chroma: fingerprinted '/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance/30 Law of the Bungle, Part II.flac'
chroma: matched recordings [u'9ee85934-557e-48da-ae10-043e38aacec5'] on releases [u'2d1d2d5e-3e33-48cf-8e02-7f81cef886b5']
Looking up: /mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance
Tagging Jethro Tull - A Passion Play: An Extended Performance
Searching for discovered album ID: 2d1d2d5e-3e33-48cf-8e02-7f81cef886b5
Sending event: albuminfo_received
Candidate: Jethro Tull - A Passion Play: An Extended Performance
Success. Distance: 0.43
Album ID match recommendation is Recommendation.low
Search terms: Jethro Tull - A Passion Play: An Extended Performance
Album might be VA: False
Sending event: albuminfo_received
chroma: acoustid album candidates: 1
Sending event: albuminfo_received
Sending event: albuminfo_received
Sending event: albuminfo_received
Sending event: albuminfo_received
Sending event: albuminfo_received
Sending event: albuminfo_received
Evaluating 6 candidates.
Candidate: Jethro Tull - A Passion Play: An Extended Performance
Duplicate.
Candidate: Jethro Tull - A Passion Play
Success. Distance: 0.82
Candidate: Jethro Tull - A Passion Play
Success. Distance: 0.83
Candidate: Jethro Tull - A Passion Play
Success. Distance: 0.82
Candidate: Jethro Tull - A Passion Play
Success. Distance: 0.86
Candidate: Jethro Tull - A Passion Play: An Extended Performance
Duplicate.

/mnt/storage/music_library/Jethro Tull/A Passion Play_ An Extended Performance (30 items)
Sending event: before_choose_candidate
Tagging:
    Jethro Tull - A Passion Play: An Extended Performance
URL:
    http://musicbrainz.org/release/2d1d2d5e-3e33-48cf-8e02-7f81cef886b5
(Similarity: 56.7%) (missing tracks) (4xCD, 2014, US, Chrysalis)
CD 1: A Passion Play (A new Steven Wilson stereo remix)
CD 2: The Château D’Hérouville Sessions (A new Steven Wilson stereo remix)
Missing tracks (64/94 - 68.1%):
 ! Lifebeats / Prelude (5.1 mix) (#31) (3:24)
 ! The Silver Cord (5.1 mix) (#32) (4:28)
 ! Re-Assuring Tune (5.1 mix) (#33) (1:11)
 ! Memory Bank (5.1 mix) (#34) (4:20)
 ! Best Friends (5.1 mix) (#35) (1:56)
 ! Critique Oblique (5.1 mix) (#36) (4:35)
 ! Forest Dance #1 (5.1 mix) (#37) (1:34)
 ! The Story of the Hare Who Lost His Spectacles (5.1 mix) (#38) (4:10)
 ! Forest Dance #2 (5.1 mix) (#39) (1:12)
 ! The Foot of Our Stairs (5.1 mix) (#40) (5:08)
 ! Overseer Overture (5.1 mix) (#41) (3:58)
 ! Flight From Lucifer (5.1 mix) (#42) (3:56)
 ! 10:08 to Paddington (5.1 mix) (#43) (1:04)
 ! Magus Perdé (5.1 mix) (#44) (3:53)
 ! Epilogue (5.1 mix) (#45) (0:44)
 ! Lifebeats / Prelude (#46) (3:24)
 ! The Silver Cord (#47) (4:28)
 ! Re-Assuring Tune (#48) (1:11)
 ! Memory Bank (#49) (4:20)
 ! Best Friends (#50) (1:56)
 ! Critique Oblique (#51) (4:35)
 ! Forest Dance #1 (#52) (1:34)
 ! The Story of the Hare Who Lost His Spectacles (#53) (4:10)
 ! Forest Dance #2 (#54) (1:12)
 ! The Foot of Our Stairs (#55) (5:08)
 ! Overseer Overture (#56) (3:58)
 ! Flight From Lucifer (#57) (3:56)
 ! 10:08 to Paddington (#58) (1:04)
 ! Magus Perdé (#59) (3:53)
 ! Epilogue (#60) (0:44)
 ! A Passion Play, Part 1 (original 1973 stereo mix) (#61) (23:08)
 ! A Passion Play, Part 2 (original 1973 stereo mix) (#62) (22:00)
 ! The Story of the Hare Who Lost His Spectacles (tour footage) (#63) (7:21)
 ! Opening/Closing Ballet Sequences (tour footage) (#64) (3:56)
 ! The Big Top (5.1 mix) (#65) (3:05)
 ! Scenario (5.1 mix) (#66) (3:25)
 ! Audition (5.1 mix) (#67) (2:33)
 ! Skating Away on the Thin Ice of the New Day (5.1 mix) (#68) (3:27)
 ! Sailor (5.1 mix) (#69) (3:10)
 ! No Rehearsal (5.1 mix) (#70) (5:09)
 ! Left Right (5.1 mix) (#71) (5:02)
 ! Only Solitaire (5.1 mix) (#72) (1:28)
 ! Critique Oblique, Part I (5.1 mix) (#73) (8:50)
 ! Critique Oblique, Part II (5.1 mix) (#74) (5:28)
 ! Animelee (1st Dance) (5.1 mix) (#75) (3:36)
 ! Animelee (2nd Dance) (5.1 mix) (#76) (1:34)
 ! Law of the Bungle, Part I (5.1 mix) (#77) (5:08)
 ! Tiger Toon (5.1 mix) (#78) (2:31)
 ! Law of the Bungle, Part II (5.1 mix) (#79) (5:28)
 ! The Big Top (#80) (3:05)
 ! Scenario (#81) (3:25)
 ! Audition (#82) (2:33)
 ! Skating Away on the Thin Ice of the New Day (#83) (3:27)
 ! Sailor (#84) (3:10)
 ! No Rehearsal (#85) (5:09)
 ! Left Right (#86) (5:02)
 ! Only Solitaire (#87) (1:28)
 ! Critique Oblique, Part I (#88) (8:50)
 ! Critique Oblique, Part II (#89) (5:28)
 ! Animelee (1st Dance) (#90) (3:36)
 ! Animelee (2nd Dance) (#91) (1:34)
 ! Law of the Bungle, Part I (#92) (5:08)
 ! Tiger Toon (#93) (2:31)
 ! Law of the Bungle, Part II (#94) (5:28)
Apply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort?

Led to this problem:

(4xCD, 2014, US, Chrysalis)

Setup

My configuration (output of beet config) is:

plugins: lastgenre replaygain ftintitle fetchart embedart lastgenre info lyrics chroma scrub

directory: /mnt/storage/music_library
library: ~/Documents/library.db

match:
   preferred:
      media: ['CD']

import:
   write: yes
   move: yes
lastgenre:
   canonical: yes
   count: 3
   separator: ', '
replaygain:
   backend: gstreamer
scrub:
   auto: yes
sampsyo commented 8 years ago

Thanks for the report! Currently, the fields that keeps track of the media and count (AlbumInfo.media and AlbumInfo.mediums) are only aware of a single media type. We should keep track of the full list of media types and report that.

apastuszak commented 8 years ago

Woohoo!

My first enhancement request!

On Wed, Sep 21, 2016 at 8:57 PM, Adrian Sampson notifications@github.com wrote:

Thanks for the report! Currently, the fields that keeps track of the media and count (AlbumInfo.media and AlbumInfo.mediums) are only aware of a single media type. We should keep track of the full list of media types and report that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beetbox/beets/issues/2203#issuecomment-248784649, or mute the thread https://github.com/notifications/unsubscribe-auth/ADPlXjXZhhFyphfPI4we4mBn39HdoGxMks5qsdJtgaJpZM4KCyf9 .