search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.92k stars 1.82k forks source link

Incorrect ReplayGain tag writing for AAC files #2426

Closed apastuszak closed 7 years ago

apastuszak commented 7 years ago

Problem

I used beets convert to convert my music library from FLAC to AAC using ffmpeg and libfdk_aac. The following command is being used to do the conversion in the config.yaml.

command: ffmpeg -i $source -c:a libfdk_aac -b:a 256k $dest

It appears album gain information is being written improperly. album gain, album peak, and track peak values are identical, and foobar2000 claims the files have no album gain info.

Running this command in verbose (-vv) mode:

user configuration: /home/andy/.config/beets/config.yaml
data directory: /home/andy/.config/beets
plugin paths: 
Sending event: pluginload
lyrics: Disabling google source: no API key configured.
rewrite: adding template field artist シートベルツ
inline: adding item field multidisc
library database: /home/andy/Documents/library.db
library directory: /mnt/storage/music_library
Sending event: library_opened
Bleachers - Strange Desire - Wild Heart
Bleachers - Strange Desire - Rollercoaster
Bleachers - Strange Desire - Shadow
Bleachers - Strange Desire - I Wanna Get Better
Bleachers - Strange Desire - Wake Me
Bleachers - Strange Desire - Reckless Love
Bleachers - Strange Desire - Take Me Away feat. Grimes
Bleachers - Strange Desire - Like a River Runs
Bleachers - Strange Desire - You're Still a Mystery
Bleachers - Strange Desire - I'm Ready to Move On / Wild Heart Reprise feat. Yoko Ono
Bleachers - Strange Desire - Who I Want You to Love
Convert? (Y/n) y
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/01 Wild Heart.flac
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/02 Rollercoaster.flac
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/04 I Wanna Get Better.flac
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/03 Shadow.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/02 Rollercoaster.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/05 Wake Me.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/01 Wild Heart.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/06 Reckless Love.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/04 I Wanna Get Better.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/07 Take Me Away feat. Grimes.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/03 Shadow.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/08 Like a River Runs.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/05 Wake Me.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/09 You're Still a Mystery.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/07 Take Me Away feat. Grimes.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/10 I'm Ready to Move On _ Wild Heart Reprise feat. Yoko Ono.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/06 Reckless Love.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Encoding /mnt/storage/music_library/Bleachers/Strange Desire/11 Who I Want You to Love.flac
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/08 Like a River Runs.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/09 You're Still a Mystery.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/10 I'm Ready to Move On _ Wild Heart Reprise feat. Yoko Ono.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
convert: Finished encoding /mnt/storage/music_library/Bleachers/Strange Desire/11 Who I Want You to Love.flac
Sending event: write
Sending event: after_write
convert: embedding album art from /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
convert: embedding /mnt/storage/music_library/Bleachers/Strange Desire/cover.jpg
Sending event: write
Sending event: after_write
Sending event: after_convert
Sending event: cli_exit

beet info on the track Roller Coaster:

/mnt/storage/music_library/Bleachers/Strange Desire/02 Rollercoaster.flac
acoustid_fingerprint: 
         acoustid_id: 
               album: Strange Desire
         albumartist: Bleachers
  albumartist_credit: Bleachers
    albumartist_sort: Bleachers
       albumdisambig: 
         albumstatus: Official
           albumtype: album
                 art: True
              artist: Bleachers
       artist_credit: Bleachers
         artist_sort: Bleachers
                asin: B00KFU303O
            bitdepth: 16
             bitrate: 976388
                 bpm: 0
          catalognum: 307166
            channels: 2
            comments: 
                comp: False
            composer: 
             country: US
                date: 2014-07-15
                 day: 15
                disc: 1
           disctitle: 
           disctotal: 1
             encoder: FLAC 1.2.1
              format: FLAC
               genre: Indie Pop, Alternative Rock, Rock
              genres: Indie Pop, Alternative Rock, Rock
            grouping: Alternative
               label: RCA
            language: eng
              length: 188.866666667
              lyrics: It was summer when I saw your face
But like a teenage runaway
Oh god I never thought we'd take it that far
Some killer queen you are

Now I'm running and I can't stop anywhere I go
I think about it everyday and night I can't let go
Man, I'm never the same
We were shot gun lovers I was shot gun running away

So come a little closer
There was something I could tell ya
You were such a rollercoaster
And a killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are

We took the bones out from the road
Those endless nights that we traveled we stole
You let your clothes fall to the floor
And lit a fire while I waited for more

Now I'm running and I won't stop I don't wanna go
I think about it everyday and night I can't let go
And hey, I'm never the same
It's a hundred miles an hour on a dirt road running away

So come a little closer
There was something I could tell ya
You were such a rollercoaster
And a killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer claimed it all

Come a little closer
I'm sure, come a little closer

Why don't you come a little closer
There was something I could tell ya
You were such a rollercoaster
Some killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are
    mb_albumartistid: 58e235fc-f6ea-4614-9ed4-9855a5665ae1
          mb_albumid: c2418376-2c16-416d-84a6-bd045f0464dd
         mb_artistid: 58e235fc-f6ea-4614-9ed4-9855a5665ae1
   mb_releasegroupid: aa6d9840-3382-430e-9282-df8df90bfe9a
          mb_trackid: b229b809-b822-48b3-9166-f746047a4307
               media: CD
               month: 7
       original_date: 2014-07-15
        original_day: 15
      original_month: 7
       original_year: 2014
       rg_album_gain: -8.51
       rg_album_peak: 1.000031
       rg_track_gain: -10.28
       rg_track_peak: 1.000031
          samplerate: 44100
              script: Latn
               title: Rollercoaster
               track: 2
          tracktotal: 11
                year: 2014

AAC File beet info

/home/andy/lossy-music/Bleachers/Strange Desire/02 Rollercoaster.m4a
acoustid_fingerprint: 
         acoustid_id: 
               album: Strange Desire
         albumartist: Bleachers
  albumartist_credit: Bleachers
    albumartist_sort: Bleachers
       albumdisambig: 
         albumstatus: Official
           albumtype: album
            arranger: 
                 art: True
              artist: Bleachers
       artist_credit: Bleachers
         artist_sort: Bleachers
                asin: B00KFU303O
            bitdepth: 16
             bitrate: 256006
                 bpm: 0
          catalognum: 307166
            channels: 2
            comments: 
                comp: False
            composer: 
             country: US
                date: 2014-07-15
                 day: 15
                disc: 1
           disctitle: 
           disctotal: 1
             encoder: FLAC 1.2.1
              format: AAC
               genre: Indie Pop, Alternative Rock, Rock
              genres: Indie Pop, Alternative Rock, Rock
            grouping: Alternative
               label: RCA
            language: eng
              length: 188.913106576
            lyricist: 
              lyrics: It was summer when I saw your face
But like a teenage runaway
Oh god I never thought we'd take it that far
Some killer queen you are

Now I'm running and I can't stop anywhere I go
I think about it everyday and night I can't let go
Man, I'm never the same
We were shot gun lovers I was shot gun running away

So come a little closer
There was something I could tell ya
You were such a rollercoaster
And a killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are

We took the bones out from the road
Those endless nights that we traveled we stole
You let your clothes fall to the floor
And lit a fire while I waited for more

Now I'm running and I won't stop I don't wanna go
I think about it everyday and night I can't let go
And hey, I'm never the same
It's a hundred miles an hour on a dirt road running away

So come a little closer
There was something I could tell ya
You were such a rollercoaster
And a killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer claimed it all

Come a little closer
I'm sure, come a little closer

Why don't you come a little closer
There was something I could tell ya
You were such a rollercoaster
Some killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are

Rollercoaster, I don't say no
Rollercoaster, When you don't say no
And it's such a rollercoaster
Some killer queen you are
    mb_albumartistid: 58e235fc-f6ea-4614-9ed4-9855a5665ae1
          mb_albumid: c2418376-2c16-416d-84a6-bd045f0464dd
         mb_artistid: 58e235fc-f6ea-4614-9ed4-9855a5665ae1
   mb_releasegroupid: aa6d9840-3382-430e-9282-df8df90bfe9a
          mb_trackid: b229b809-b822-48b3-9166-f746047a4307
               media: CD
               month: 7
       original_date: 2014-07-15
        original_day: 15
      original_month: 7
       original_year: 2014
       rg_album_gain: 1.000031
       rg_album_peak: 1.000031
       rg_track_gain: -10.28
       rg_track_peak: 1.000031
          samplerate: 44100
              script: Latn
               title: Rollercoaster
               track: 2
          tracktotal: 11
                year: 2014
$ beet -vv convert Bleachers Strange Desire

Led to this problem:

Album gain info that  is not working

Here's a link to the music files that trigger the bug (if relevant):

Setup

My configuration (output of beet config) is:

plugins: lastgenre replaygain ftintitle fetchart embedart lastgenre info lyrics chroma scrub inline web convert rewrite

directory: /mnt/storage/music_library
library: ~/Documents/library.db
per_disc_numbering: yes
asciify_paths: yes
match:
   preferred:
      media: ['CD']

import:
   write: yes
   move: yes
   timid: yes
lastgenre:
   canonical: yes
   count: 3
   separator: ', '
replaygain:
   backend: bs1770gain
   auto: yes
   overwrite: yes
scrub:
   auto: yes
paths:
    default: $albumartist/$album %if{%aunique{},[$label - $year]}/%if{$multidisc,$disc-}$track $title
item_fields:
    multidisc: 1 if disctotal > 1 else 0
web:
    host: 192.168.1.3

convert:
    auto: no
    copy_album_art: yes
    dest: /home/andy/lossy-music
    embed: yes
    never_convert_lossy_files: yes
    format: aac
    formats:
        aac:
            command: ffmpeg -i $source -c:a libfdk_aac -b:a 256k $dest
            extension: m4a
rewrite:
    artist シートベルツ: The Seatbelts
sampsyo commented 7 years ago

In the future, please use code brackets surrounding pastes from the terminal (i.e., three backticks at the top and bottom), which makes things much more readable.

It looks like this is the important part. The "before" output:

rg_album_gain: -8.51
rg_album_peak: 1.000031
rg_track_gain: -10.28
rg_track_peak: 1.000031

and the "after" output:

rg_album_gain: 1.000031
rg_album_peak: 1.000031
rg_track_gain: -10.28
rg_track_peak: 1.000031

Something happened to the album gain/peak values. I'll investigate further.

apastuszak commented 7 years ago

I apologize. I'll go clean up the bug.

On Wed, Feb 1, 2017 at 11:42 AM, Adrian Sampson notifications@github.com wrote:

In the future, please use code brackets surrounding pastes from the terminal (i.e., three backticks at the top and bottom), which makes things much more readable.

It looks like this is the important part. The "before" output:

rg_album_gain: -8.51 rg_album_peak: 1.000031 rg_track_gain: -10.28 rg_track_peak: 1.000031

and the "after" output:

rg_album_gain: 1.000031 rg_album_peak: 1.000031 rg_track_gain: -10.28 rg_track_peak: 1.000031

Something happened to the album gain/peak values. I'll investigate further.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beetbox/beets/issues/2426#issuecomment-276709353, or mute the thread https://github.com/notifications/unsubscribe-auth/ADPlXswzVksrXxAcWAEQp6v2r6UY2dmbks5rYLXmgaJpZM4Lz_mw .

sampsyo commented 7 years ago

Awesome; thank you! :sparkles:

apastuszak commented 7 years ago

Is that better?

sampsyo commented 7 years ago

Yes; thank you!

apastuszak commented 7 years ago

The bug is marked as "needinfo." Are you waiting on something from me?

sampsyo commented 7 years ago

Nope, it was just waiting for me to reproduce the problem.

From some initial tests, it looks like this might be a more general problem—not necessarily related to convert. Do you have any AAC files in your beets library? If so, can you check whether it's possible to use beet modify rg_album_gain to even manually change their album gain level? That is, if you make this change, does the change show up in beet info or foobar2000 or anywhere else?

Thanks!

apastuszak commented 7 years ago

Sure. I can do some testing. I'll get back to you later today.

Andy

On Sat, Feb 4, 2017 at 2:55 PM, Adrian Sampson notifications@github.com wrote:

Nope, it was just waiting for me to reproduce the problem.

From some initial tests, it looks like this might be a more general problem—not necessarily related to convert. Do you have any AAC files in your beets library? If so, can you check whether it's possible to use beet modify rg_album_gain to even manually change their album gain level? That is, if you make this change, does the change show up in beet info or foobar2000 or anywhere else?

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

sampsyo commented 7 years ago

Great; thanks!

In fact, as an update: l did a little more digging and tracked the bug down to the way that we're manipulating RG tags on AAC files. I've just pushed a fix for that, so this may actually be totally cleared up. So if you can, please get the latest source and try your convert operation again; things may now "just work."

apastuszak commented 7 years ago

So, here's a beet info on a iTunes track I purchased and imported into beets.

/mnt/storage/music_library/Alan Parsons/All Our Yesterdays/01 All Our Yesterdays.m4a
acoustid_fingerprint: 
         acoustid_id: 
               album: All Our Yesterdays
         albumartist: Alan Parsons
  albumartist_credit: Alan Parsons
    albumartist_sort: Parsons, Alan
       albumdisambig: 
         albumstatus: Official
           albumtype: single
                 art: True
              artist: Alan Parsons
       artist_credit: Alan Parsons
         artist_sort: Parsons, Alan
                asin: B003TZBJ44
            bitdepth: 16
             bitrate: 256000
                 bpm: 0
          catalognum: 
            channels: 2
            comments: 
                comp: False
            composer: Alan Parsons (SESAC)
             country: 
                date: 2010-06-15
                 day: 15
                disc: 1
           disctitle: 
           disctotal: 1
             encoder: 
              format: AAC
               genre: Progressive Rock, Rock
              genres: Progressive Rock, Rock
            grouping: Progressive Rock
               label: 
            language: eng
              length: 271.092970522
              lyrics: The stakes are high
We have to seize the chance
A case of do or die
This is our last dance

A moment's hesitation and we always pay the price
Hiding in the wings is just like walking on thin ice

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

The vision is too real
The prize is there to take
We're on an even keel
No demons in our way

If you stack the cards you will one day find your heaven
Both sides of the dice are always adding up to seven

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

Yesterday's tomorrow is tomorrow's yesterday
Destiny's forgotten, there's another game to play
No more future perfect we just need the present tense
All our yesterdays are only hanging in suspense

Hang the banners high
On the outward walls
The battles lost and won
That's when the hammer falls

Racing to the future we must never lose our way
All we have to do is take tomorrow's chance today

All our yesterdays have come of age
Now we all can sing a different song
All our yesterdays have all departed
The writing on the wall will soon be gone

All our yesterdays (all our yesterdays)
Now we all can sing a different song
All our yesterdays (all our yesterdays)
The writing on the wall will soon be gone

All our yesterdays have come of age
The writing on the wall will soon be gone
    mb_albumartistid: 9774cfd1-8862-42bd-919e-156c31f079b4
          mb_albumid: 659273b9-85a2-4724-b6e2-b92e2d9e307e
         mb_artistid: 9774cfd1-8862-42bd-919e-156c31f079b4
   mb_releasegroupid: d8548732-b19c-4e50-a3e8-479f895f7fef
          mb_trackid: 5d4607d4-8756-4f40-9423-5fd9b73a842f
               media: Digital Media
               month: 6
       original_date: 2010-06-15
        original_day: 15
      original_month: 6
       original_year: 2010
       rg_album_gain: 0.993073
       rg_album_peak: 0.9931
       rg_track_gain: -5.71
       rg_track_peak: 0.9931
          samplerate: 44100
              script: Latn
               title: All Our Yesterdays
               track: 1
          tracktotal: 2
                year: 2010
apastuszak commented 7 years ago

Reimported again to make sure the latest version of beets tagged it:

acoustid_fingerprint: AQADtIoSZkkSRdJg5bjx4VNwXBqO48dz3Mdx8DE-Hp-RH-qD6B9eFz7sfngVfMNLa4iWHS705SS-GumP72DIHaeY4ktE_A16wt2LXDNErch9NKES4bmCo3wR5ketHGKmyvh1ofnxLDseBtMiJcgdfONwCj82LkOqHtYN_Sq-hEW9lTg-o8lRVkcvwfXxHD7OtIPG7DG-4sFzNDmeR_iUA1eO77jwHD5ODrIXWCi-oz90eM2HJ8gpDf_Q48sRnrCPH7SaQedxLcGFQzyDx_hxHdZRbcQZLYOOo1ceaHkGHh8jCkd4wQ9yZTj64x_QVEnxFDr47cOf4ztO5bg9ONIGZYgv4vCLPBa-NFmhL3wQnUIf_GgQbuIHPTlOJciHRnFaVMqJ8AfvFm9gFz2uKDk6uDz6HZqpGP2Or-gLT4a240WPVPjxvMT74Dxu-EIuoscPrRdx9vjhMdFR1MoO-chu41xy9OlxXviF8oF1I8uJklkODT-K09HwW9Au4wv643_wIO1xpI_gQ9dRLRTCpVsD5xJ4-Ecp52iP5riCm8h34Ye2i7iM1DmeBX5x8XgX-DheGj8uRjnKRMlxMPFRPcV3dDlS9uBJo1eM89BmeFKFUzj8BSc-wbuhvcWXEz2P_MGPcwdZ-MRx37iQK3h31GLEQEfhMzSew4-MH5cenB-8HmUOvcHNoDv8C6Gsg_0RNnAs5fghyhEqM0ApMfBxBT_KLrgWaIfVPDh69A-aTkcN32hVtCm2G-cjuCEOH104oXIgXkapHHkkYUdJBmnt4EelQ590vCFeMFc84Dp4ejCe48dd4YlmfPhx5McZ3DH64zfKRUdTJXh0GbnQKjpBHV8UvPgDX4Ke4fjhDzkHXzku5D0OjQ9xHz_C_Oi440eP9HzAE96gq0V3nEfeI0ft4SdExpgebgi9HI8x_rhwbOGPvjiDMM_RVQqmH3rCGIbP410Qd4Wfo6yOqVIUpNMw_cUzaDlK2cHlDpWkLLAqVHqFY1cstCOJrUoEN83wRMU3Br-F5sc9C08vZKO-oDl-9IskfDFunEfjlugl_EKY7OiYRMF_nOHxU8RJ9DA_Ejdz6Ogn5ETl47nQyMP3IU926CKyPMV18B9ew6_Qh8cp5OmC_0GDp9nhihm0h8fHIPwZgbCTmeh3XMFJI9d5XIL2I2fmHI8Y-CilIE8lQreO-OlwWhQaxhEq1DYaSUYoFVpO5AGexKgvMLlxIfzRxMXzo2F3sNJnNMeRXx2yrLngH32DT8eJHs2V4D7xRXmQ80VfxHyOt2gqKcchlfvxvGisWdBVvDrE-GAu3Md54dqH62h2aFfwB3mi49FnfAk-ghfxaWg4Fu-GK8NLIvl15NnRCzfRWzkcMRJMRR86HK0MJjvyC7UNXwq8CbQPXTqOP2QKH6V-PEGfQT-cw3q0otpoQVeSdQlqTmiOnHiOXwjjHj_hC-_hU4F2DmEk5kGp3-CB5jwq6kRvpE6QfISNhwpxmTneH3-OO8OjC3mYES-hH-JZgTlCJyUeLT8-_D98pkJv5Al0ET-a10SZG7E0nLgW9MnhZYlRLkf4w3qg_XiWB7l0DZWPX8jULejxiYdeJT7-Qg-HUzh3FM_xH1ZwIVf2ojmL56jh1CwcSj8eFqmSXdB0Fmd-9Gj6D28m4Ttcm7iDGzh1_JAyaUfP4BdC4zB-5FfQG3dyVNxwHRke4ZeDH36O4jS-4xnyoxfxUIJY4lLAD_nBKzh8ZkXKBReNXkkaHF0JKTlO41TwC7Ee9NxgbUevCE06oaKDn3jyIIx6aBdxGVc0PJegPcQvIj9-pXA2ItcliD9qhxNCNkKzH3dq9DlyE7sCccxQeUlxXOrx-FAU6gnKCz9ynCIuHexxEfnxB7py9EjvBT9BLc_QXSZ6pFdSof6DH2eEsIf3GL1sfHjQH96F50JO5rA44Yf8o1yIE_U-NG-JnMdj9FZAqchVDrZGoT-eQjxxHMyj43iIrllEMNCZwj365pCn7DiP0kP6CRfIRScuPTC_oOTxIg-mLcd5eNXRfh2-YGc41M1hdbBYaM9QsYfroB_u4zvaXRAffM7xY7ZSIleOZ8UvXB9yufCk6NAuHBWlo9ka7L5QjTuaZyP-HOcW4Ql6wl9C9HkglTx-IUzaVuh24voQ5nWKajyhKRHODT3zgaUSKiJ0HLlw52CvoInjoVV4fA6QHb0GZVlFCS_qHKHha0VPfDoefDiP8C-aPMNTXkSOiUpTCf6H_PiO7crRS9Cp4ydylsF05bCP4l2JG9W2I1Wzg4mjHaqP0AofmLdhHhVF48mMb0OIBvrxqIoE9wxQG0wSetA1aPTxHCHn48eJMGdLaMiP80djj6h9vAgp5oIkJzNSTopH9PgzoT8aUSSu40deSDkP_8J34YOz6HiNM-gLnT-eJCwm_2hGLiry5vhT4t3x5McjhUWzR-jZ4cqNI5eg6URO7Mf3RPDzCwEQMoYhYIBBBJNmkKOAACaIYEgoQBARDgBgBBJAIcEEIUA4AQgQglAqmFIIAEAYR8oQBjAhjjKEBTICCkcQBYggRpA4khCBHRKKSIQQpIBRhQxhnAkDOBAUGTKYcAoBIQhAwgAlnAMAAKGAAoYgkQgBVgAgBCGECsIIEYYQhQw1gjEjhFBOAMEIEAAZAxwRBBojhHAKAAOooYgo4AgChjHEkAEEWMQkIgQ6ARkgBizjjDPCMKCZIEYgJIQQgiEjgCPAOUIgEEJIwghAxEGgBDBACCKQYQhoY5giRCgGkCGOKIWQIIIRKIwgzChGkFONMGMMAkIADQwSglhkNSCQCCEIEwgYJAiSwABgiGFCEKcEQggBb4ABCCDCCDAEGSAIRQZ4xYAAwAlEhGGOMGSQg4QRQYQgAhkAgBIGUAEQQlAwoYQCQiAJDABKCUqAQQ4AQQhAQhjgADBMSKUcUkIAIohiihAltHCOAGIAEgYjAYgjwBhCBBWCAaMUMhAaoJAhCjFskQIEKQaYEQAuowAASgRCgEICG2MAUpQgBQhTgCmAADACIMsIEoQAIgQwwjBmgBIEMCAEAMQQiwAQEAGjDAGCGCEUVUIRIIBBREhGBEKUEGScEIwoBgAXQDmHADHSCOEMdQoAZQQzFAhmAJKGOWUMZQYC5AESEDRgnBBIEEOUAogLJ5gwDAgEjBEAAWIUJIgJ5YBRgiHAHSGCIIaIAkAKIKggTBjBhHSGCeCAYMwQoigxAlHgBBDSIAIAYQJAQhQyVCJkDHAGKEWUQMQgAJBDgiJGEAHCEiEIEkIAJAQxAgkDHCBMAGYEEkoJRLwChAGpsBDIAICBNAA54gBQBggpmCISOAUAB4gYZYgxgCFGhgIACaKZAkZIRpGDghiCgKKMMCCEYUIYQAxAhAhIhGMFKMIMEQIA
         acoustid_id: 48b6ac15-ee29-4229-9e0f-67af98e43de4
               album: All Our Yesterdays
         albumartist: Alan Parsons
  albumartist_credit: Alan Parsons
    albumartist_sort: Parsons, Alan
       albumdisambig: 
         albumstatus: Official
           albumtype: single
            arranger: 
                 art: True
              artist: Alan Parsons
       artist_credit: Alan Parsons
         artist_sort: Parsons, Alan
                asin: B003TZBJ44
            bitdepth: 16
             bitrate: 256000
                 bpm: 0
          catalognum: 
            channels: 2
            comments: 
                comp: False
            composer: Alan Parsons (SESAC)
             country: 
                date: 2010-06-15
                 day: 15
                disc: 1
           disctitle: 
           disctotal: 1
             encoder: 
              format: AAC
               genre: Progressive Rock, Rock
              genres: Progressive Rock, Rock
            grouping: Progressive Rock
               label: 
            language: eng
              length: 271.092970522
            lyricist: 
              lyrics: The stakes are high
We have to seize the chance
A case of do or die
This is our last dance

A moment's hesitation and we always pay the price
Hiding in the wings is just like walking on thin ice

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

The vision is too real
The prize is there to take
We're on an even keel
No demons in our way

If you stack the cards you will one day find your heaven
Both sides of the dice are always adding up to seven

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

Yesterday's tomorrow is tomorrow's yesterday
Destiny's forgotten, there's another game to play
No more future perfect we just need the present tense
All our yesterdays are only hanging in suspense

Hang the banners high
On the outward walls
The battles lost and won
That's when the hammer falls

Racing to the future we must never lose our way
All we have to do is take tomorrow's chance today

All our yesterdays have come of age
Now we all can sing a different song
All our yesterdays have all departed
The writing on the wall will soon be gone

All our yesterdays (all our yesterdays)
Now we all can sing a different song
All our yesterdays (all our yesterdays)
The writing on the wall will soon be gone

All our yesterdays have come of age
The writing on the wall will soon be gone
    mb_albumartistid: 9774cfd1-8862-42bd-919e-156c31f079b4
          mb_albumid: 659273b9-85a2-4724-b6e2-b92e2d9e307e
         mb_artistid: 9774cfd1-8862-42bd-919e-156c31f079b4
   mb_releasegroupid: d8548732-b19c-4e50-a3e8-479f895f7fef
          mb_trackid: 5d4607d4-8756-4f40-9423-5fd9b73a842f
               media: Digital Media
               month: 6
       original_date: 2010-06-15
        original_day: 15
      original_month: 6
       original_year: 2010
       rg_album_gain: 0.993073
       rg_album_peak: 0.9931
       rg_track_gain: -5.71
       rg_track_peak: 0.9931
          samplerate: 44100
              script: Latn
               title: All Our Yesterdays
               track: 1
          tracktotal: 2
                year: 2010
sampsyo commented 7 years ago

OK! I'm not totally sure what to look for in these outputs… are there expected values for the SoundCheck data generated by iTunes?

apastuszak commented 7 years ago

I haven't tried the new commit yet. You beat me to posting my beet info output. I'll give it a try. I assume I need to compile from source, and can't just do an updated through pip?

sampsyo commented 7 years ago

An ordinary pip install won't work, but it's not too complicated: you can follow the instructions in the FAQ. http://docs.beets.io/en/v1.4.3/faq.html#run-the-latest-source-version-of-beets

apastuszak commented 7 years ago

Ok, retagged the above aac song that was in my library. Here are the results:

/home/andy/Music/Alan Parsons/All Our Yesterdays/01 All Our Yesterdays.m4a
acoustid_fingerprint: 
         acoustid_id: 
               album: All Our Yesterdays
         albumartist: Alan Parsons
  albumartist_credit: Alan Parsons
    albumartist_sort: Parsons, Alan
       albumdisambig: 
         albumstatus: Official
           albumtype: single
            arranger: 
                 art: True
              artist: Alan Parsons
       artist_credit: Alan Parsons
         artist_sort: Parsons, Alan
                asin: B003TZBJ44
            bitdepth: 16
             bitrate: 256000
                 bpm: 0
          catalognum: 
            channels: 2
            comments: 
                comp: False
            composer: Alan Parsons (SESAC)
             country: 
                date: 2010-06-15
                 day: 15
                disc: 1
           disctitle: 
           disctotal: 1
             encoder: 
              format: AAC
               genre: Progressive Rock, Rock
              genres: Progressive Rock, Rock
            grouping: Progressive Rock
               label: 
            language: eng
              length: 271.09297052154193
            lyricist: 
              lyrics: The stakes are high
We have to seize the chance
A case of do or die
This is our last dance

A moment's hesitation and we always pay the price
Hiding in the wings is just like walking on thin ice

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

The vision is too real
The prize is there to take
We're on an even keel
No demons in our way

If you stack the cards you will one day find your heaven
Both sides of the dice are always adding up to seven

All our yesterdays will soon be ending
Hide the walking shadow on the stage
All our yesterdays be soon forgotten
There's an easy way to turn the page

Yesterday's tomorrow is tomorrow's yesterday
Destiny's forgotten, there's another game to play
No more future perfect we just need the present tense
All our yesterdays are only hanging in suspense

Hang the banners high
On the outward walls
The battles lost and won
That's when the hammer falls

Racing to the future we must never lose our way
All we have to do is take tomorrow's chance today

All our yesterdays have come of age
Now we all can sing a different song
All our yesterdays have all departed
The writing on the wall will soon be gone

All our yesterdays (all our yesterdays)
Now we all can sing a different song
All our yesterdays (all our yesterdays)
The writing on the wall will soon be gone

All our yesterdays have come of age
The writing on the wall will soon be gone
    mb_albumartistid: 9774cfd1-8862-42bd-919e-156c31f079b4
          mb_albumid: 659273b9-85a2-4724-b6e2-b92e2d9e307e
         mb_artistid: 9774cfd1-8862-42bd-919e-156c31f079b4
   mb_releasegroupid: d8548732-b19c-4e50-a3e8-479f895f7fef
          mb_trackid: 5d4607d4-8756-4f40-9423-5fd9b73a842f
               media: Digital Media
               month: 6
       original_date: 2010-06-15
        original_day: 15
      original_month: 6
       original_year: 2010
       rg_album_gain: -5.47
       rg_album_peak: 0.9931
       rg_track_gain: -7.17
       rg_track_peak: 0.993103
          samplerate: 44100
              script: Latn
               title: All Our Yesterdays
               track: 1
          tracktotal: 2
                year: 2010

Need to tinker some more, but it looks like it's fixed!

apastuszak commented 7 years ago

FooBar2000 is seeing album gain data! Marking this closed.

Thank you for fixing this!

sampsyo commented 7 years ago

Yay! Thanks for giving that a try.

Barafu commented 7 years ago

This bug has another effect. With every beet update -p it tried to rewrite tags on m4a files again and again. This seems to be gone now too.