beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.71k stars 1.81k forks source link

bs1770gain fails #3428

Closed tecosaur closed 4 years ago

tecosaur commented 4 years ago

Problem

Running this command in verbose (-vv) mode:

$ beet -vv replaygain
user configuration: /home/tec/.config/beets/config.yaml
data directory: /home/tec/.config/beets
plugin paths:
Sending event: pluginload
error: replaygain initialization failed: bs1770gain exited with status 1

Led to this problem:

error: replaygain initialization failed: bs1770gain exited with status 1

Which happened after adding this this config

replaygain:
    backend: bs1770gain

Setup

My configuration (output of beet config) is:

plugins: fetchart embedart replaygain lyrics lastgenre convert web chroma discogs fuzzy play

directory: ~/Music
library: ~/Music/library.db

paths:
    default: $albumartist/$album%aunique{}/$disc-$track $title
    singleton: Non-Album/$artist/$title
    comp: Compilations/$album%aunique{}/$disc-$track $title

per_disc_numbering: yes
ignore_hidden: yes
threaded: yes

import:
    write: yes
    copy: yes
    move: no
    resume: ask
    # incremental: yes
    timid: no
    log: ~/.config/beets/import.log

convert:
    auto: no
    threads: 12
    max_bitrate: none
    no_convert: format:mp3, format:flac

ui:
    color: yes

web:
    host: 127.0.0.177

lyrics:
    fallback: ''
    google_API_key: THIS_LOOKS_SENSITIVE

fetchart:
    google_key: THIS_LOOKS_SENSITIVE

discogs:
    user_token: THIS_LOOKS_SENSITIVE

replaygain:
    auto: yes
    backend: bs1770gain
sampsyo commented 4 years ago

Please see https://github.com/beetbox/beets/issues/3367.

tecosaur commented 4 years ago

I see thanks. Looks like my google-fu wasn't good enough.

So, fixed in the next release?

tecosaur commented 4 years ago

Oh also, a quick query (might as well ask here), would you happen to know whether the replaygain plugin adds the --replaygain arg to bs1770 to normalise to -18 LUFS as specified in RG 1/2 as opposed to the default -23?

sampsyo commented 4 years ago

Sorry, not off the top of my head—but this shouldn't be too hard to answer by looking at the source code.

tecosaur commented 4 years ago

I see, and just to confirm: this issue is fixed in the next release. Yes?

sampsyo commented 4 years ago

Yes.

jackwilsdon commented 4 years ago

@tecosaur looking at the "bs1770gain" section of the ReplayGain plugin documentation, it seems like we default to --replaygain: https://beets.readthedocs.io/en/v1.3.17/plugins/replaygain.html#configuration