search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.91k stars 1.82k forks source link

Show whether a match option is a duplicate #351

Open sampsyo opened 11 years ago

sampsyo commented 11 years ago

In the candidate chooser screen, we should "preview" whether the album already exists in the library (i.e., whether the duplicate checker will be tripped if the album is selected). Suggestion due to @willscott.

discopatrick commented 6 years ago

@sampsyo - I'm noticing that during the import process, duplicates are not queried by a musicbrainz ID as I had expected, but actually by a query for the album and albumartist, making the concept of a duplicate more "fuzzy" than I had thought it was. https://github.com/beetbox/beets/blob/9f945a7c556f0c369bb9d19455a46f550233f9fd/beets/importer.py#L659-L662

The feature I was planning to add to beets was to show whether a match option was an exact musicbrainz match.

Is the latter something you'd be happy to have in beets? And if so, should I incorporate it into the same pull request?

sampsyo commented 6 years ago

Sounds interesting! Sure, matching my MusicBrainz release ID seems like a reasonable option—would this be a new configuration option?

It would be great if the match-choice screen used the same behavior as the post-facto duplicate detector, whatever that's configured to be.

discopatrick commented 6 years ago

Great idea - allow the user to choose what the definition of a "duplicate" is in the config.

8h2a commented 6 years ago

Additionally to choosing the definition of a duplicate it would be nice if we could display more information for those duplicates. E.g. some users may want to print the path, id, catalognum, tracks, files, ...

Related issues: Show more info when asking about duplicated album #1131 Importer duplicate detection: configurable field set #1133 In duplicate resolution prompt, list the tracks in the “old” album #2852 Choose which albums to remove/merge when adding duplicates #2809