Closed j-peeters closed 2 years ago
Thanks! This looks like a recently-introduced bug. The root cause is a function that expects a Source
object but is actually receiving a string.
The commit that introduced this bug is 316b79f72fd5c4f39e4d14b417c7bb5fd8864e4a by @wisp3rwind.
Thanks for fixing this! I'm a total newbie with branches, masters, fixes etc. If I want to use this fix, how do I update Beets to include this new fix? I'm currently on the 1.5 version.
The FAQ has instructions: https://beets.readthedocs.io/en/stable/faq.html#run-the-latest-source-version-of-beets
@sampsyo Side question about that: I notice the docs don't mention the pattern:
git clone git://github.com/beetbox/beets
cd beets
pip install -e .
to install beets from source in editable mode. Should we add it? The advantage is that you can then hack on your beets working copy, and the changes are immediately reflected in your environment without needing to run python setup.py install
every time. This is how I've been developing my beets plugins, and I find it very convenient. Or is there some downside to pip install -e
that I don't know (I'm not super expert at python)?
Edit: Reading more carefully, I see that pip install -e
is the third option listed... but using the "automatic source checkout" approach. So I guess the distinction here is merely whether you clone it manually yourself, and therefore get to decide where the sources go? *shrug*
Edit 2: I filed #4084 suggesting an addition to the FAQ about pip install -e .
. Please feel free to close if it's not to your liking.
Problem
The Lyrics plugin throws an error/crashes when ran without BeautifulSoup installed.
Terminal output
I currently can't run a verbose command because Beets is dragging itself through finding lyrics for many many albums.
The following error is displayed in Terminal when running:
After installing BeautifulSoup the output is
Andrew writes:
Setup
My configuration (output of
beet config
) is: