search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.57k stars 1.8k forks source link

db: disable DQS on Python >= 3.12 #5235

Open wisp3rwind opened 1 month ago

wisp3rwind commented 1 month ago

cf. https://github.com/beetbox/beets/issues/4709, let's see how badly this breaks CI

wisp3rwind commented 1 month ago

ah, the Ubuntu LTS on CI has an ancient SQLite...

sungo commented 1 month ago

to preface, I know precisely jack about python. I'm cutting and pasting to try and get my setup back online :) but after rolling a python 3.12 pyenv on freebsd, I tried this patch. it doesn't work for me unless those 0s are changed to 1s. so conn.setconfig(sqlite3.SQLITE_DBCONFIG_DQS_DDL, 1) etc.

with that change, I seem to be up and running again on freebsd 13.1

edit: sorry. I've been a bit desperate here :) it occurs to me that of course you're actually trying to ferret out DQS problems in the build so you can fix them. however, the inverse of what you're trying to do fixed my setup on freebsd which has been frustrating the hell out of me the last little while :)

wisp3rwind commented 1 month ago

Oh, but if DQS can still be enabled at runtime, we could merge that change quickly as a workaround until we really remove all DQS usage (at least if the latter turns out to be a lot of work).