Fix for #4709 - Githubissues

beetbox / beets

music library manager and MusicBrainz tagger

http://beets.io/

MIT License

12.78k stars 1.82k forks source link

Fix for #4709 #5236

Closed arogl closed 2 days ago

arogl commented 4 months ago

Description

Fixes #4709.

Changelog to complete if testing works out

To Do

[ ] Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)

arogl commented 4 months ago

Doing further testng with #5235 enabled on windows to compare failures

arogl commented 4 months ago

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

arogl commented 4 months ago

Thsi should be good of further tetsing before merging. I'll try out on Ubuntu 24.04 (WSL), and teh latest version of as much as possible

wisp3rwind commented 4 months ago

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

yes, I realized the same yesterday, we should revisit our CI first. I also remember that we used to have a run for the next Python alpha; we should bring that back: In particular, we already know that Python 3.13 is going to break beets due to the imghdr removal.

arogl commented 4 months ago

Tested on fully updated Arch and Ubuntu-24.04 with #5235 set with DQS=0|1

arogl commented 2 days ago

Reworked in another PR