beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.78k stars 1.82k forks source link

Add timeout argument to all `requests` calls #5262

Closed droserasprout closed 4 months ago

droserasprout commented 4 months ago

Description

Fixes bug where some plugin commands hang indefinitely. 8 years have passed since opening https://github.com/psf/requests/issues/3070, and we still have to deal with this stuff 😔 10 seconds value have been chosen as it's used multiple times in the codebase.

To Do

catap commented 4 months ago

Seems like a fix for https://github.com/beetbox/beets/issues/4103

Serene-Arc commented 4 months ago

lgtm!