beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.78k stars 1.82k forks source link

Fix the version error in the release workflow #5274

Closed Serene-Arc closed 3 months ago

Serene-Arc commented 4 months ago

This hopefully fixes the issue we experienced where the version was not incremented before the package was built. This should make sure that it works correctly.

Serene-Arc commented 4 months ago

Hey @snejus if you wanna push your markdown code to this branch, we can get it all working and fixed in one PR.

snejus commented 4 months ago

Cool, will do! To be clear, do you mean the code that converts rst changelog to md?

Serene-Arc commented 4 months ago

Yes, the part I removed. I removed a bunch of stuff but if you actually have it working, then we might as well add it back in. It'll be a bit of a pain to make it so it's output as part of the action (which is why I removed it in the first place) but it should be manageable.

snejus commented 4 months ago

@Serene-Arc thanks for the confirmation - this makes sense. I don't think this should pose too many issues - let me get on it.

snejus commented 3 months ago

@Serene-Arc See the commits I have just pushed

snejus commented 3 months ago

See the resulting changelog for 2.0.0 below

With this release, beets now requires Python 3.7 or later (it removes support for Python 3.6).

Major new features

New features

Bug fixes

For plugin developers

For packagers

Other changes

snejus commented 3 months ago

I rebased the PR off the most recent master @Serene-Arc .

Serene-Arc commented 3 months ago

Cool, thanks. I've reviewed the changes and it seems good to me. I'll merge and we can make another release whenever.