search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.78k stars 1.82k forks source link

Add aliases support #5277

Open sezaru opened 4 months ago

sezaru commented 4 months ago

Description

This PR add support for aliases to releases, release-groups and recordings.

This PR is a must have (IMO at least) for people that listen to Japanese, Chinese and other songs that has other symbols for letters. With this, not only the artist name will use the alias if available, but now the album and track name will also use aliases.

NOTE: This PR requires a fork of the python-musicbrainzngs package. That package seems to be dead (more than 2 years without any commit) and is lacking in a lot of updates to Musicbrainz API.

Here is my PR adding support for the new fields https://github.com/alastair/python-musicbrainzngs/pull/289 but I have no hope that will be merged since the package seems to be dead.

Personally I think beets can create a fork of that package and just add the bare minimum to it to make new features work (for example this one).

I didn't add any tests and changelog changes yet since this PR requires forking python-musicbrainzngs, so first I want to discuss if this can be merged and then after getting the confirmation I will add the missing parts.

Serene-Arc commented 3 months ago

I would really like this functionality. However, there is #4936, which completely replaces the musicbrainzngs package and instead embeds that functionality in beets itself. That seems like the best option, given that the other project is more or less dead.

I would ask you to consider looking at that PR and how you can use it, since I will begin reviewing it now.