Closed bal-e closed 2 weeks ago
I'm using this as a quick testing ground for #5305, hence the strange rebase. I'll re-adjust it once the checks complete.
Restored, ready for review / merge.
Hmm, does this impact calling beets on the command with beet
?
In a venv, I ran poetry install
and checked $(which beet)
. It's definitely a different script than the one I removed from the repository (I'm sure it's automatically generated):
#!<path/to/my/venv>/bin/python
import sys
from beets.ui import main
if __name__ == '__main__':
sys.exit(main())
So as long as Poetry is being used to build beets
, which it should be, everything should be fine. Even the /usr/bin/beet
which is part of the Arch Linux beets
package looks like a different file.
Wonderful, should be fine to remove then.
For context: The script that is actually being installed is generated by poetry via the sripts
configuration in pyproject.toml
(previously, it was generated via entry_points
in setup.py
.
Great, wasn't entirely sure and I thought it best to double check! Don't want to suddenly be unable to use beet as a command
Yeah, absolutely! Honestly, I should've investigated how the actual beet
executable was generated a bit better before making the PR. Thanks for making sure!
Description
This is a very simple PR, just removing the (apparently unused)
beet
executable from the repository and substitutingbin/env python
forbin/python3
where possible.Fixes #4604.
To Do