search

beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.57k stars 1.8k forks source link

Fix changelog reminder workflow #5305

Closed snejus closed 2 weeks ago

snejus commented 2 weeks ago

Quote the breaking glob as noted by @bal-e.

snejus commented 2 weeks ago

I was expecting it to remind me to update the changelog on this PR too 🕵🏼 🤨

bal-e commented 2 weeks ago

I'm going to try rebasing #5303 on top of this to trigger the changelog action.

bal-e commented 2 weeks ago

@snejus, is it possible that it's using the version of the workflow that's on the master branch?

snejus commented 2 weeks ago

Not sure, I think there's only one way to test it 🤷🏼‍♂️ at least now we know it shouldn't break!

Serene-Arc commented 2 weeks ago

How bizarre. This is why testing GH actions are such a pita. They run in very strange ways. If you look at the checks, it hasn't been attempted. Maybe there's a restriction on running jobs that are being updated?

Serene-Arc commented 2 weeks ago

It might still be running the version on master, rather than the one on the PR?

bal-e commented 2 weeks ago

Yeah, maybe we should just try merging this PR and seeing if it helps. I can't think of a better option, which sucks.

Serene-Arc commented 2 weeks ago

GitHub actions and CI are amazing and useful but not easy to test and honestly, half of the time the only way TO test it is to push to production and just see what breaks. When I was writing the release workflow, I pushed to MY repo, and did a bunch of breaking changes, and then just reset it to upstream. And it still didn't find everything.

snejus commented 2 weeks ago

I think it's happier now: https://github.com/beetbox/beets/actions/runs/9525145560/job/26258903712

Serene-Arc commented 2 weeks ago

Wonderful