beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.92k stars 1.82k forks source link

Duplicates plugin doc does not mention explicitly the effect of `--full` on copy/move/delete #5408

Open nado opened 2 months ago

nado commented 2 months ago

Problem

As title says, here are the mention of the argument and the config block:

https://beets.readthedocs.io/en/stable/plugins/duplicates.html

-F, --full            show all versions of duplicate tracks or albums
full: List every track or album that has duplicates, not just the duplicates themselves. Default: no

The copy/move/delete flags all mention taking effects on "matched" items, but nowhere can we read that the matched items are the one listed by the command and not the "files other than the best elected file to keep", which lead me to apply the move command to all my versions of duplicates. Either reword copy/move/delete, or the --full to state that it "modifies the matched items to include all version of duplicate tracks/albums", which would then be consistent across the different options.

bal-e commented 1 month ago

So using -F and -m together resulted in all your files being moved to a different directory?

We can note that effect on the website docs and in the CLI output (basically show all ... => operate on all ...). Does that sound adequate?

The behavior you found is quite strange, perhaps combining -F and -m should result in an error.

nado commented 1 month ago

Sounds great to me.