scrub: Restore album art during automatic scrubbing

[l-t-k]

As mentioned earlier, the scrub plugin removes the embedded art file from the tags. An option to enable / disable this behaviour would be great!

I'm running beets 1.3.3

[sampsyo]

Thanks for splitting this out into a separate bug. The plugin should (and in my tests, does) restore album art after scrubbing.

In order to reproduce this bug, could you provide a sample file where scrub removes the art? Steps to reproduce (e.g., import, test for art, scrub, test for art again) would also help a lot here.

[l-t-k]

I tried it many times with different albums, but the plugin always deletes the embedded art. I can't figure out what goes wrong.

My config file look like this:

library: /root/.config/beets/music.blb
directory: /mnt/wd1/files/music/albums
per_disc_numbering: yes
import:
    copy: yes
    move: yes
    write: yes
    resume: ask
    quiet_fallback: skip
    timid: no
    log: /var/log/beets.txt
ignore: .AppleDouble ._* *~ .DS_Store
plugins: scrub lastgenre inline
threaded: yes
color: yes

item_fields:
    disc_unpadded: str(disc)

paths:
    albumtype:soundtrack: new/soundtrack/$albumartist_sort/[$year] $album/$disc_unpadded$track $artist - $title
    albumartist:various artists: new/various artist/$albumartist_sort/[$year] $album/$disc_unpadded$track $artist - $title
    default: new/artist/$albumartist_sort/[$year] $album/$disc_unpadded$track $artist - $title

lastgenre:
    source: album
    count: 1
    min_weight: 20
    fallback: 'Onbekend'

match:
    strong_rec_thresh: 0.30
    ignored: missing_tracks unmatched_tracks
    preferred:
        countries: ['GB|UK', 'US', 'NL']
        media: ['CD', 'Digital Media|File']
        original_year: yes

[l-t-k]

An example verbose import action:

root@media1:~# beet -v import /mnt/wd1/files/downloads/music
data directory: /root/.config/beets
library database: /root/.config/beets/music.blb
library directory: /mnt/wd1/files/music/albums
Sending event: import_task_start
Looking up: /mnt/wd1/files/downloads/music/Eminem - The Marshall Mathers LP 2 _2013_
Tagging Eminem - The Marshall Mathers LP 2
No album IDs found.
Search terms: Eminem - The Marshall Mathers LP 2
Album might be VA: False
Evaluating 5 candidates.
Candidate: Eminem - The Marshall Mathers LP 2
Success. Distance: 0.024280
Candidate: Eminem - The Marshall Mathers LP 2
Success. Distance: 0.025337
Candidate: Eminem - The Marshall Mathers LP 2
Success. Distance: 0.128505
Candidate: Eminem - The Marshall Mathers LP 2
Success. Distance: 0.126898
Candidate: Eminem - The Marshall Mathers LP 2
Success. Distance: 0.138126

/mnt/wd1/files/downloads/music/Eminem - The Marshall Mathers LP 2 _2013_ (16 items)
Tagging:
    Eminem - The Marshall Mathers LP 2
(Similarity: 97.6%) (country, tracks) (CD, 2013, XW)
 * Rhyme Or Reason                    -> Rhyme or Reason
 * Asshole (feat. Skylar Grey) (4:27) -> Asshole (4:48) (length, title)
 * The Monster (feat. Rihanna)        -> The Monster (title)
 * Love Game (feat. Kendrick Lamar)   -> Love Game (title)
 * Headlights (feat. Nate Ruess)      -> Headlights (title)
Sending event: import_task_choice
Sending event: import_task_apply
0 of 16 items replaced
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
lastfm.tag (min. 20): rap [66]
added last.fm album genre (album): Rap
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/103 Eminem - Rhyme or Reason.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/105 Eminem - Survival.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/109 Eminem - Rap God.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/107 Eminem feat. Skylar Grey - Asshole.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/101 Eminem - Bad Guy.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/110 Eminem - Brainless.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/102 Eminem - Parking Lot (skit).mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/111 Eminem - Stronger Than I Was.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/112 Eminem feat. Rihanna - The Monster.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/113 Eminem - So Far.._.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/115 Eminem feat. Nate Ruess - Headlights.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/108 Eminem - Berzerk.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/116 Eminem - Evil Twin.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/114 Eminem feat. Kendrick Lamar - Love Game.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/106 Eminem - Legacy.mp3
Sending event: item_moved
Sending event: database_change
Sending event: database_change
Sending event: write
auto-scrubbing /mnt/wd1/files/music/albums/new/artist/Eminem/[2013] The Marshall Mathers LP 2/104 Eminem - So Much Better.mp3
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: import_task_files
Sending event: album_imported
Sending event: import
Sending event: cli_exit

[sampsyo]

Ah, thank you for clarifying! Yes, it looks like we only restore embedded art for explicit beet scrub commands, not during automatic scrubbing. We should fix that.

[msolli]

I'd like to weigh in by saying that I really like the fact that embedded art is removed during scrubbing. It can help reduce disk usage significantly in a large library. So please make this an option to enable/disable it.

[sampsyo]

Interesting; good to know. We should put this behind a config option when we implement it.

[l-t-k]

Is there any news about this bug? I think it is still weird behavior to embed art followed by a scrub. This means, in my case, beets is useless as a auto tagger when the embedart/fetchart & scrub plugin are combined?

[sampsyo]

No news that's not listed here. If you're interested, please consider contributing.

[sampsyo]

Fixed in #1657.