beetbox / beets

music library manager and MusicBrainz tagger
http://beets.io/
MIT License
12.9k stars 1.82k forks source link

Convert Stripping Tags #822

Closed haok2 closed 10 years ago

haok2 commented 10 years ago

Convert plugin is stripping all tags using auto-scrubbing. How can I stop this from occuring?

Here's an output -

Started encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac convert: executing: ffmpeg -i '/media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'"'"'S Go.flac' -y -aq 4 '/media/mx/archive/mp3/The Cars/Candy-O/01 - Let'"'"'S Go.mp3' Started encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/02 - Since I Held You.flac convert: executing: ffmpeg -i '/media/mpd/music/The Cars/24-96Khz/Candy-O/02 - Since I Held You.flac' -y -aq 4 '/media/mx/archive/mp3/The Cars/Candy-O/02 - Since I Held You.mp3' Finished encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac Sending event: write auto-scrubbing /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac [zero] genre: -> None [zero] day: 0 -> None [zero] comments: -> None [zero] month: 0 -> None Finished encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/02 - Since I Held You.flac Sending event: after_write Sending event: after_convert Started encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/03 - It'S All I Can Do.flac convert: executing: ffmpeg -i '/media/mpd/music/The Cars/24-96Khz/Candy-O/03 - It'"'"'S All I Can Do.flac' -y -aq 4 '/media/mx/archive/mp3/The Cars/Candy-O/03 - It'"'"'S All I Can Do.mp3' Sending event: write auto-scrubbing /media/mpd/music/The Cars/24-96Khz/Candy-O/02 - Since I Held You.flac [zero] genre: -> None [zero] day: 0 -> None [zero] comments: -> None [zero] month: 0 -> None Sending event: after_write Sending event: after_convert

haok2 commented 10 years ago

Here's the relevant section from the config.yaml file :+1:

convert: ffmpeg: /usr/bin/ffmpeg embed: true format: mp3 max_bitrate: 256 opts: -aq 4 dest: /media/mx/archive/mp3 threads: 2 paths: default: %title{$albumartist/$album%aunique{}/$disc_and_track - $title} comp: %title{Various/$album%aunique{}/$disc_and_track - $title} singleton: %title{Non-Album/$artist/$title} albumtype:soundtrack: %title{Soundtracks/$composer/$album%aunique{}/$disc_and_track - $title} albumtype:soundtrack: %title{Soundtracks/$albumartist/$album%aunique{}/$disc_and_track - $title}

sampsyo commented 10 years ago

Can you elaborate about what you perceive to be going wrong? If I were to guess, I would say that you have both convert and scrub enabled and you're doing an import. You're finding that the FLAC has tags but the MP3 has no tags for some reason?

A lot more detail would be helpful here.

haok2 commented 10 years ago

Thanks for your reply.

I am converting .flac files to mp3 files using the convert plugin. In the example above the command was beet -v convert "Candy-O".

When running this command all tags are stripped from the source flac files. I would not expect the convert plugin to strip metadata from the library. It should preserve the source information not alter it.

sampsyo commented 10 years ago

Yes, certainly.

And are you saying that one or both of the files is missing tags? If so, which? And what software did you use to check that the tags were missing?

haok2 commented 10 years ago

The tags are lost in the source flac files. They are retained in the converted mp3 files.

I can see this using puddletag and also MusicBrainz Picard. Also, the files are lost in my Andorid MPD client MPDroid.

haok2 commented 10 years ago

I have removed scrub plugin and this behaviour has stopped. I thought scrub plugin was only used on an import command.

The following line no longer appears in the verbose output :

auto-scrubbing /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac

haok2 commented 10 years ago

Here's the output without scrub pluign activated :+1:

henry@audio ~/.config/beets $ beet -v convert "Candy-O" user configuration: /home/henry/.config/beets/config.yaml Sending event: pluginload adding template field artist The Jimi Hendrix Experience adding template field artist Tom Petty & The Heartbreakers adding template field artist Ryan Adams and The Cardinals adding template field artist Iron And Wine inline: adding item field disc_and_track Sending event: library_opened data directory: /home/henry/.config/beets library database: /media/mpd/config/beets/music.blb library directory: /media/mpd/music The Cars - Candy-O - Let's Go The Cars - Candy-O - Since I Held You The Cars - Candy-O - It's All I Can Do The Cars - Candy-O - Double Life The Cars - Candy-O - Shoo Be Doo The Cars - Candy-O - Candy-O The Cars - Candy-O - Night Spots The Cars - Candy-O - You Can't Hold On Too Long The Cars - Candy-O - Lust for Kicks The Cars - Candy-O - Got a Lot on My Head The Cars - Candy-O - Dangerous Type Convert? (Y/n) y Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/02 - Since I Held You.flac (target file exists) Started encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac convert: executing: ffmpeg -i '/media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'"'"'S Go.flac' -y -aq 4 '/media/mx/archive/mp3/The Cars/Candy-O/01 - Let'"'"'S Go.mp3' Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/03 - It'S All I Can Do.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/04 - Double Life.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/05 - Shoo Be Doo.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/06 - Candy-O.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/07 - Night Spots.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/08 - You Can'T Hold On Too Long.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/09 - Lust For Kicks.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/10 - Got A Lot On My Head.flac (target file exists) Skipping /media/mpd/music/The Cars/24-96Khz/Candy-O/11 - Dangerous Type.flac (target file exists) Finished encoding /media/mpd/music/The Cars/24-96Khz/Candy-O/01 - Let'S Go.flac Sending event: write [zero] genre: -> None [zero] day: 0 -> None [zero] comments: -> None [zero] month: 0 -> None Sending event: after_write Sending event: after_convert Sending event: cli_exit

sampsyo commented 10 years ago

Thanks for the details. Just to check, are you on the latest version of beets? We fixed something similar in 1.3.6.

haok2 commented 10 years ago

Yes. Here's the output :

beets version 1.3.6 plugins: duplicates, embedart, fetchart, rewrite, mpdupdate, discogs, mbcollection, convert, the, mbsync, zero, info, inline

sampsyo commented 10 years ago

Great; thanks for all the details. I found the bug (it was a recent regression) and pushed a fix just now.