search

beetbox / mediafile

elegant audio file tagging
http://mediafile.readthedocs.io/
MIT License
100 stars 25 forks source link

tests fail due to updated mutagen version #2

Closed ghost closed 7 years ago

ghost commented 8 years ago

See this https://github.com/beetbox/beets/pull/2088 and potentially other changes to mediafile https://github.com/beetbox/beets/commits/master/beets/mediafile.py

jackwilsdon commented 8 years ago

I'm considering nuking the history here (i.e. force pushing) and rebasing the changes made in beetbox/beets onto here.

It's how I created the history in the first place and it shouldn't hurt to do it again? I know force pushing is bad but it seems the best way really, as this is kind of still "up in the air" at the moment.

ghost commented 8 years ago

I think at least one more force push should be done, but can we save it until we split from beets? You folks said that 1.4.0 would be the release in which we'd split beets, and that's the next one. Can we split now?

ghost commented 8 years ago

Oh, and if we do, then it's time to stop allowing 3.x failures on travis (and maybe appveyor too)

jackwilsdon commented 8 years ago

@jrobeson: Well the force push would be needed to actually split from beets, as it would bring us up to date with the version of mediafile.py that is currently in beets.

I'll sort out the tests being ignored too.

ghost commented 8 years ago

I thought that's what i said? what led to the impression i meant otherwise? wanna pop in irc?

jackwilsdon commented 8 years ago

Ah, I understood this part of what you said:

but can we save it until we split from beets

As meaning "only do it after splitting from beets" 😆. I can't join IRC right now sadly but I should be on soon (possibly tomorrow).

ghost commented 8 years ago

I understand now, sorry for the confusion. I meant that as in "right before we split"

sampsyo commented 8 years ago

Yes! I fully endorse force-pushing to this repo while the split is still in flux.

sampsyo commented 7 years ago

I've done a bit more work to bring things up to speed, and this bug has gone away.

Currently, the mediafile.py here and in the beets repository match exactly (except for the copyright line). So if anyone's interested in preserving the ancient MF history, it would be safe to replace all the history here with that history—in other words, it's safe to transition now.