search

beetbox / mediafile

elegant audio file tagging
http://mediafile.readthedocs.io/
MIT License
100 stars 25 forks source link

Add RELEASETYPE mapping for albumtype and RELEASESTATUS mapping for albumstatus #28

Closed jeandeaual closed 4 years ago

jeandeaual commented 4 years ago

According to the Picard tag mappings documentation, the "Release Status" tag is mapped to MUSICBRAINZ_ALBUMSTATUS for APEv2 and RELEASESTATUS for Vorbis comments and the "Release Type" tag is mapped to MUSICBRAINZ_ALBUMTYPE for APEv2 and RELEASETYPE for Vorbis comments.

Currently, mediafile only reads and writes MUSICBRAINZ_ALBUMSTATUS in albumstatus for Vorbis comments and APEv2, so it doesn't pick up the value in FLAC files edited with Picard.

Same thing for albumtype, RELEASETYPE should be supported alongside MUSICBRAINZ_ALBUMTYPE.

sampsyo commented 4 years ago

Nice! This seems good to me. Would you mind adding a quick note to the changelog?

jeandeaual commented 4 years ago

I updated the changelog. Is that fine?

sampsyo commented 4 years ago

Looks great; thanks again!!