beetbox / mediafile

elegant audio file tagging
http://mediafile.readthedocs.io/
MIT License
100 stars 26 forks source link

Tests for saving ID3v2.3 #44

Open JuniorJPDJ opened 3 years ago

JuniorJPDJ commented 3 years ago

I think we should have some tests for this as It's supported but not checked if works. I'm pretty sure big part of multi-valued tags would fail and this should be only expected failure.

sampsyo commented 3 years ago

That seems like a good idea. For exceptions, this seems straightforward. For other (non-failure) cases, would we just check "round-trip" preservation of data?

JuniorJPDJ commented 3 years ago

I was thinking about using same test set as for other formats, just change saving to id3v2.3 for new "format". Would also need to set some failures as expected but it doesn't seem to hard to do.