search

beetbox / mediafile

elegant audio file tagging
http://mediafile.readthedocs.io/
MIT License
100 stars 26 forks source link

Add the properties bitrate_mode, encoder_info and encoder_settings #58

Closed jcassette closed 3 years ago

jcassette commented 3 years ago

Thanks, I have updated the doc index :-)

jcassette commented 3 years ago

I have also added the properties encoder_info and encoder_settings since they are available. This will allow to get information about the VBR quality, even though it would be better if mutagen exposed it directly.

sampsyo commented 3 years ago

Nice; this all seems great!!

The style checker has one suggestion: a few of the places where there's a dictionary literal, like this:

'encoder_info' : '',

Should have one less space, like this:

'encoder_info': '',

Otherwise, I think this is good to go. Thanks again for sorting this out!

jcassette commented 3 years ago

Oops, I removed the extra spaces, thank you!

sampsyo commented 3 years ago

Awesome; thanks!! I bumped this to v0.9.0 to indicate a new feature, but I think it's good to go.