search

beetbox / mediafile

elegant audio file tagging
http://mediafile.readthedocs.io/
MIT License
97 stars 24 forks source link

multi-valued tags for artists + albumartists sort and credits #69

Closed jmbannon closed 1 year ago

jmbannon commented 1 year ago

As title, for the PR: https://github.com/beetbox/beets/pull/4743

On Ubuntu, I'm hitting a pre-existing test failure on WAVETest.test_read_audio_properties when reading the bitrate tag: 88200 != 705600

sampsyo commented 1 year ago

Looks good overall! I wouldn't worry too much about the bitrate mismatch; it likely has to do with the underlying version of Mutagen (but in any case it's not a big deal).

Could you please add a quick changelog entry here? https://github.com/beetbox/mediafile/blob/master/docs/index.rst#changelog

Then we should be good to go!

jmbannon commented 1 year ago

@sampsyo Done!

sampsyo commented 1 year ago

Excellent; thanks!

jmbannon commented 1 year ago

When you get some time @sampsyo , mind updating pypi with 0.11.1? Then I can update the beets PR's pip dep with this change

sampsyo commented 1 year ago

I've actually published it as v0.12.0 (following the SemVer recommendation to bump the minor version for new features). Thanks again!