Add force_use_fpcalc kwarg for fingerprinting

beetbox / pyacoustid

Python bindings for Chromaprint acoustic fingerprinting and the Acoustid Web service

MIT License

330 stars 66 forks source link

Add force_use_fpcalc kwarg for fingerprinting #49

Closed johnlawsharrison closed 5 years ago

johnlawsharrison commented 5 years ago

Addresses #48

Allows the caller to pass the kwarg force_use_fpcalc=True to, well, force fingerprinting to use fpcalc.

I opted not to name the kwarg use_fpcalc as that function signature might suggest to a user that passing the flag is the only way for fingerprinting to use fpcalc.

Example use case (as described in the issue):

when a user is unable to use audioread, but doesn't wish to manually pip uninstall it for pyacoustid to fall back to another option

johnlawsharrison commented 5 years ago

@sampsyo Let me know if I should squash this into one commit

sampsyo commented 5 years ago

No need; thanks for doing this! :sparkles: