decode_fingerprint bugfixes

beetbox / pyacoustid

Python bindings for Chromaprint acoustic fingerprinting and the Acoustid Web service

MIT License

325 stars 66 forks source link

decode_fingerprint bugfixes #78

Closed albertopasqualetto closed 1 year ago

albertopasqualetto commented 1 year ago

Here are some bug fixes for decode_fingerprint calulation which, at this moment, raises exception:

chromaprint.decode_fingerprint function raises TypeError, in fact it needs a fingerprint as the parameter, in the file variables a and b are tuples (duration, fingerprint) since they are output of fingerprint_file function.
list.max raised exception saying that list has no attribute max, in fact the correct function is max(list)

New code is tested both on Windows 11 and Ubuntu 20.

sampsyo commented 1 year ago

Hi, @bindestriche—since you added this feature in #75, could you please take a look at these changes? Both of these intuitively seem right, but it would be great to get confirmation.

bindestriche commented 1 year ago

@albertopasqualetto is completely correct.

sampsyo commented 1 year ago

Excellent; thank you both!!