search

beetbox / pyacoustid

Python bindings for Chromaprint acoustic fingerprinting and the Acoustid Web service
MIT License
332 stars 66 forks source link

latest pip version does not include compare function #80

Closed bindestriche closed 1 year ago

bindestriche commented 1 year ago

Installing the pip package to confirm the latest pull request, I noticed the compare function no not being present. see https://gist.github.com/bindestriche/06f9693c550ddabe4d1e3e7a557098fe

sampsyo commented 1 year ago

Indeed; we haven't released a new version for v1.3.0 yet. It's convenient that we delayed in order to find the bugs in #78… maybe it would be prudent to give it a moment to make sure we're confident in this state before we cut another release?

bindestriche commented 1 year ago

While I understand your reasoning, I think because we are not changing existing functionality, it is okay to make the feature available to a wider audience. We will not be breaking any existing codebases. The further spread will make it more likely to receive bug reports.

a --pre / pre-release package sounds like the right solution here.

albertopasqualetto commented 1 year ago

This issue has been solved and so should be closed.