search

beetee17 / pe

0 stars 0 forks source link

Lack of validation for phone numbers #6

Open beetee17 opened 2 years ago

beetee17 commented 2 years ago

Users are allowed to enter any combination of digits as long as it is 3 digits long.

This may cause confusion for users that accidentally type a wrong number (miss a digit or add extra digit), and would not realise that anything was wrong.

nus-se-script commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

It is possible to have longer or shorter numbers if you are calling e.g. an extension line, or an international number. We do not make any assumption about the length of phone numbers in this app, leaving the user with flexibility in deciding what they want to save as their contact's phone number.

Moreover, it is impossible to verify the validity of a number without accessing external APIs, which would violate the given constraints of the tP.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]