beethovenxfi / frontend-v2

Frontend Vue app for Balancer exchange and pool management.
https://app.balancer.fi
MIT License
8 stars 20 forks source link

rm trailing slash from etherscan link; was resulting in '//' in urls #132

Closed gerrrg closed 2 years ago

gerrrg commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any new dependencies that are required for this change.

Etherscan URLs have double slashes. Ex:

This extremely minor edit removes the trailing slash of the etherscan link.

Fixes # (issue) n/a

Type of change

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

Checklist:

vercel[bot] commented 2 years ago

@gerrrg is attempting to deploy a commit to the beethovenx Team on Vercel.

A member of the Team first needs to authorize it.

groninge01 commented 2 years ago

@gerrrg Can you switch this PR to go to the beethovenx-optimism branch?

gerrrg commented 2 years ago

@groninge01 just updated it 👍

danielmkm commented 2 years ago

Thank you kindly sir!!

danielmkm commented 2 years ago

It looks like when you switched the branch it created more changes than you intended gerrg

groninge01 commented 2 years ago

It looks like when you switched the branch it created more changes than you intended gerrg

Ah you probably branched from beethovenx-staging. Sorry I forgot to mention the Optimism deploy is in it's own 'hard' branch for the moment.

gerrrg commented 2 years ago

Whoops, you're totally right. Was just going fast and not paying attention -- hang tight

gerrrg commented 2 years ago

Closing in favor of 136