beethovenxfi / frontend-v2

Frontend Vue app for Balancer exchange and pool management.
https://app.balancer.fi
MIT License
8 stars 20 forks source link

Remove unused code #94

Open groninge01 opened 2 years ago

groninge01 commented 2 years ago

@danielmkm

App.vue:

danielmkm commented 2 years ago

useGnosisSafeApp could be useful at some point, but isn't being used now, it allows easier interaction with the app with a multisig.

useExploitWatcher what does it do when you has an address that is part of an exploit?

groninge01 commented 2 years ago

useExploitWatcher what does it do when you has an address that is part of an exploit?

You get an alert with a message. I checked the balancer version and it is still the same.

danielmkm commented 2 years ago

ok, get rid of it then

groninge01 commented 2 years ago

@danielmkm

AppNavSettings: What are these v-if's about?

<div v-if="!hideLiquidity" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('tradeLiquidity')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('whichPools')" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="tradeLiquidityOptions" v-model="appTradeLiquidity" @update:modelValue="setTradeLiquidity" />
</div>
<div v-if="isEIP1559SupportedNetwork" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('transactionType')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('ethereumTxTypeTooltip')" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="ethereumTxTypeOptions" v-model="ethereumTxType" @update:modelValue="setEthereumTxType" />
</div>
<div v-if="ENABLE_LEGACY_TRADE_INTERFACE && isGnosisSupportedNetwork" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('tradeInterface')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('tradeInterfaceTooltip')" class="w-52" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="tradeInterfaceOptions" v-model="appTradeInterface" @update:modelValue="setTradeInterface" />
    <div class="flex mt-1"></div>
</div>