Include curses in macOS support package

beeware / Python-Apple-support

A meta-package for building a version of Python that can be embedded into a macOS, iOS, tvOS or watchOS project.

MIT License

1.11k stars 160 forks source link

Include curses in macOS support package #109

Closed samschott closed 3 years ago

samschott commented 3 years ago

As discussed in https://github.com/beeware/briefcase/issues/516, this PR includes curses in the support package.

MacOS already comes with ncurses bundled so we only need to include Python package and extension module, increasing the size of the support package by roughly 0.3 MB.

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

samschott commented 2 years ago

Seems like curses was removed again from the Python 3.10 macOS build. Was this intentional?

samschott commented 2 years ago

Hm, I think this was a side effect of 7b35fc5.

freakboy3742 commented 2 years ago

Oh drat. No, it wasn't intentional; I got overzealous with some refactoring.

We (by which I mean, probably I) really do need to work out how to do an automated release test on these builds...

samschott commented 2 years ago

This may be a stupid question, but why did excluding any of the other .so files not cause any problems?