Continue building if patches have already been applied

beeware / Python-Apple-support

A meta-package for building a version of Python that can be embedded into a macOS, iOS, tvOS or watchOS project.

MIT License

1.1k stars 159 forks source link

Continue building if patches have already been applied #157

Closed afh closed 2 years ago

afh commented 2 years ago

by ignoring patches that seem to be reversed or already applied.

PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[ ] I have read the CONTRIBUTING.md file
[ ] I will abide by the code of conduct

afh commented 2 years ago

Thanks for reviewing the changes in this PR, @freakboy3742, and providing more context. The motivation came from running into errors when trying to re-build the project. Yes, I've seen the oddities you mentioned, indeed very odd :)

I think the issues I ran into stem from understanding the Makefile too little and trying to build incrementally and in parallel. I'll report back should I be able to reproduce the errors I noticed reliably.