search

beeware / Python-Apple-support

A meta-package for building a version of Python that can be embedded into a macOS, iOS, tvOS or watchOS project.
MIT License
1.13k stars 165 forks source link

Fix python building to include hashlib's c helper function #40

Closed cculianu closed 6 years ago

cculianu commented 6 years ago

I submitted PR #36 through #39 for this already, but am creating an issue here just for completeness.

The basic idea is hashlib uses a C helper function to query openssl lib for the hash functions provided by it (such as ripemd160). The 1-line change PR I submitted adds the compilation of the C function to the final built libPython.a, so that hashlib can do its magic and provide all hash functions.

Without it, only a very basic set of hash functions are compiled in to libPython.a's modules. With it, you get more hash functions. It's a win/win as far as I can tell. ;)

freakboy3742 commented 6 years ago

Thanks - the build and release process takes a while, so these should start trickling into new support binaries over the next day or so.

freakboy3742 commented 6 years ago

I've just finished releasing 3.4-b6, 3.5-b7 and 3.6-b5, integrating the _hashlib changes.

cculianu commented 6 years ago

That was fast. 👍

Thank you for providing this great support lib and for briefcase and for everything else!