Fix for 'cricket-unttest run all' 922+ Fails [Window] #685 - Githubissues

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

Fix for 'cricket-unttest run all' 922+ Fails [Window] #685 #706

Closed smitar0y closed 6 years ago

smitar0y commented 6 years ago

Fix for 'cricket-unttest run all' 922+ Fails [Window] #685

Many test are failing in windows because of line separator issue .we see extra /// or ||| in string output.

As suggested by lielfr "It seems like the output from javascript does not respect the native line separator difference. Changing it to: lines1 = code1.split('\n')"

I have tested this and looks good now.

PR Checklist:

[ x] All new features have been tested
[ ] All new features have been documented
[ x] I have read the CONTRIBUTING.md file
[x ] I will abide by the code of conduct