issubclass() builtin implemented

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

issubclass() builtin implemented #740

Closed marcus290 closed 5 years ago

marcus290 commented 6 years ago

Implemented issubclass() builtin method, using the existing types.issubclass method.

Implemented the missing issubclass() builtin method

Complete implementations of Python builtins #47

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented (documentation for builtins are already in the existing code)
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

marcus290 commented 6 years ago

Tests added!

All fixed.

Revised types.issubclass() in types.js, which previously (incorrectly) processed an instance object and a class as parameters, instead of two classes.

martica commented 5 years ago

@freakboy3742 These changes look good to go in. Are you able to approve the changes that added tests?