Closed shaib closed 5 years ago
It seems that the smoke-test failure is related to the test environment and not to the PR.
Thanks @shaib for getting this PR to this point! I took your branch here and got the tests happy with it and updated against the current master.
This is an update to #485 -- I have rebased it, squashed it into 2 commits, and then added my own commits to fix the behavior where I found it to be wrong.
This also includes an improvement to the test infrastructure, to make it compare floats and complex numbers in approximation.
PR Checklist: