Add Initial Support for Python 3.7 and 3.8, Remove Support for 3.4 - Githubissues

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

Add Initial Support for Python 3.7 and 3.8, Remove Support for 3.4 #772

Closed danyeaw closed 5 years ago

danyeaw commented 5 years ago

Adds initial support for Python 3.7 and 3.8:

Adds magic numbers for 3.7 and 3.8
Add support for PEP 552 which uses 4 32-bit words in the pyc header in Python 3.7 and up
Adds all opcodes in the virtual machine, special support for the opcodes has not been added yet
Update the docs to have users use Python 3.5 and 3.6, and Node 10.x LTR
The testserver runs with Python 3.7/3.8 and Node 10.x
Some tests pass, but support for some of the new opcodes like LOAD_METHOD will come in follow on PRs.

Thanks to @freakboy3742 and @dgelessus for their help and support on gitter as I start to get my feet wet :heart:

PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[X] I have read the CONTRIBUTING.md file
[X] I will abide by the code of conduct

danyeaw commented 5 years ago

version.later and version.earlier are confusing.

This is doing version is later than 3.5.nothing, so all 3.5.0 and forward are later than that.

Thanks forgot about that :+1: