Flag tests failing as expected (by version)

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

Flag tests failing as expected (by version) #781

Closed martica closed 5 years ago

martica commented 5 years ago

This attempts to mark all the outstanding test failures as expected to allow other changes to be submitted with proper test coverage and avoid continued tests from rotting.

PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

martica commented 5 years ago

There are still a couple unexpected successes that failed locally for me, and one test failure in the 3.6 run, but looking at the error, it seems a candidate for flakiness as it depends on set ordering.

martica commented 5 years ago

Everything that fails is now marked as expected.

danyeaw commented 5 years ago

These changes look great to help use get to a state where the expected tests are passing. If we get this merged in before #772, then I can remove the Python 3.4 expected failures since we are dropping support for that version.

martica commented 5 years ago

Cool. I'm looking forward to rebasing the rest of my changes on this and seeing everything green. :)

Is there anything else that needs to be done to merge this? Brutus made some style comments that I corrected. All but the first two are marked as outdated, but even the first two have been corrected, so I'm not sure why it isn't updating to outdated.

danyeaw commented 5 years ago

@martica Thanks! :heart: