BaseException.__repr__ fixes

alexjdw commented 5 years ago

Re: Issue #803

While testing, I discovered that the current implementation of BaseException.repr had a small issue with a comma, but when I tried to fix and test I found out that it wasn't correctly implemented in many ways.

New behaviors: -- Exceptions now can accept any argument type, so long as it has a repr -- Exceptions can handle multiple arguments. -- Strings are handled separately as they need some occasional escaping, which the string repr implementation doesn't handle in the same way for some reason. Not sure if that's an issue with the string repr. -- Added questionable comma from #803 -- Multiple items print with no comma: "ValueError(1, 2)" -- Slapped on a case for JavaScript code throwing a Python exception with a repr-less javascript object.
Test added that tests all of the above.
My first implementation relied on the builtins and types helper functions, but I removed them to avoid circular references.

PR Checklist:

[ x ] All new features have been tested
[ x ] All new features have been documented
[ x ] I have read the CONTRIBUTING.md file
[ x ] I will abide by the code of conduct

martica commented 5 years ago

Looking good. Nice job filling out the functionality here.

alexjdw commented 5 years ago

Is the 3.5 test just failing right now or did I break StopIteration and nothing else?

alexjdw commented 5 years ago

Looks like I broke the first test somehow. Investigating.

martica commented 5 years ago

Probably worth merging master. We messed with the format stuff in the 3.7 branch, although I'm not sure about that message in particular.

On Wed, Jun 5, 2019 at 9:19 PM awildtechno notifications@github.com wrote:

Looks like I broke the first test somehow. Investigating.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/beeware/batavia/pull/811?email_source=notifications&email_token=AAAUWILELOBR6F2UNXKG6ATPZCF4VA5CNFSM4HSYAW72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBVYLY#issuecomment-499342383, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUWINVWI6MWVUTR7YI3HDPZCF4VANCNFSM4HSYAW7Q .

martica commented 5 years ago

Everything is looking good. I'll make the sync against master and merge it.

martica commented 5 years ago

Thanks for all the work on this. We are in a much better state for exceptions now.

beeware / batavia