Update inplace magic methods to have correct side-effects.

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 425 forks source link

Update inplace magic methods to have correct side-effects. #815

Closed martica closed 4 years ago

martica commented 5 years ago

This expands the magic method test cases to ensure that the side-effects match python better, and fixes the cases where the side-effects didn't for some inplace operators.

PR Checklist:

[x] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

phildini commented 4 years ago

Hi there! It looks like this PR might be dead, so we're closing it for now. Feel free to re-open it if you'd like to continue, or think about directing your efforts to https://github.com/beeware/briefcase or https://github.com/beeware/toga. Both of these have more active development right now. 😄